Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Unitful" to "1.0" #24

Merged

Conversation

github-actions[bot]
Copy link
Contributor

This pull request changes the compat entry for the Unitful package from 0.16.0, 0.17, 0.18 to 0.16.0, 0.17, 0.18, 1.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov-io
Copy link

codecov-io commented Jan 27, 2020

Codecov Report

Merging #24 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #24   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines          13     13           
=====================================
  Hits           13     13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d78a524...86811f9. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 86811f9 on compathelper/new_version/2020-01-27-00-03-32-068-2222519573 into d78a524 on master.

@m-wells
Copy link

m-wells commented Feb 4, 2020

@yakir12 Can we get this merged?

@yakir12 yakir12 merged commit 12bf015 into master Feb 6, 2020
@m-wells m-wells mentioned this pull request Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants