Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve link issues #68

Open
wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Resolve link issues #68

wants to merge 5 commits into from

Conversation

amc1999
Copy link

@amc1999 amc1999 commented May 11, 2021

  1. Resolve link issues:

Please keep in mind, some issues above I have not tested, it may be there are more work needs to be done. I've tested my own wiki with some extra unicode file names and it does work as expected.

  1. Add extra option to disable highlightAuto() code blocks:
gwtc --disable-highlight-auto ....

Current highlightAuto() applied by default to code blocks and it may produce unexpected results. For example some trivial 4 front spaces console output:

    2021-05-11 16:23:56 Start
    2021-05-11 16:23:56 Finish

may be displayed with unexpected rainbow color coding. That forces excessive use of plaintext and break compatibility with GitHub and GitLab. Extra --disable-highlight-auto option fix that problem.

Last, but not least: BIG thank you for github-wikito-converter

  - section links issue
  - ".md" title and TOC issue
  - non-ascii file name issue
  - link to section inside of the page itself issue

2.add extra option to disable highlightAuto() code blocks. This make results identical to GitHub and GitLab.
@hangingman
Copy link

hangingman commented Oct 29, 2021

@amc1999 I tried to install this repository with this branch by build-and-install-g,
however it requires babel. It's better to add babel-cli as devDependencies .

$ npm run build-and-install-g

> github-wikito-converter@1.5.3 build-and-install-g
> npm run build && npm install -g

> github-wikito-converter@1.5.3 build
> ./node_modules/.bin/babel src --out-dir dist --source-maps

sh: ./node_modules/.bin/babel: No such file or directory

However, it works well. Thank you !

@hangingman
Copy link

@yakivmospan @mchoraine
Would you please merge this PR ?

@amc1999
Copy link
Author

amc1999 commented Oct 29, 2021

Thank you, @hangingman

That problem quite old and coming from original limedocs/limedocs-wiki-converter sources. Missing step is to do npm install.

So, actual instructions to build and run locally:

git clone https://github.com/yakivmospan/github-wikito-converter.git
cd github-wikito-converter
npm install

npm run build-and-install-g

I've tested it on two wiki's:

cd ..
git clone https://github.com/yakivmospan/github-wikito-converter.wiki.git
gwtc ./github-wikito-converter.wiki

git clone https://github.com/openmpp/openmpp.github.io.wiki.git
gwtc ./openmpp.github.io.wiki

it works :)

I may do another PR to update readme.

@yakivmospan
Copy link
Owner

Hey @hangingman, it's a shame but I somehow missed this PR earlier. Will take a look at it asap. Thanks for your contribution!

@amc1999 amc1999 mentioned this pull request Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants