Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update all mutable stores when values are set or removed #131

Closed
yakovmanshin opened this issue Apr 30, 2024 · 0 comments · Fixed by #142
Closed

Update all mutable stores when values are set or removed #131

yakovmanshin opened this issue Apr 30, 2024 · 0 comments · Fixed by #142
Assignees
@yakovmanshin
Labels
breaking This issue breaks compatibility with previous versions new New feature or request
Milestone
v4.0.0

Comments

@yakovmanshin
Copy link
Owner

No description provided.

@yakovmanshin yakovmanshin added new New feature or request breaking This issue breaks compatibility with previous versions labels Apr 30, 2024
@yakovmanshin yakovmanshin added this to the v4.0.0 milestone Apr 30, 2024
@yakovmanshin yakovmanshin self-assigned this May 11, 2024
@yakovmanshin yakovmanshin mentioned this issue May 12, 2024
Merged
yakovmanshin added a commit that referenced this issue May 12, 2024
@yakovmanshin
[#131] Update All Mutable Stores When Setting or Removing Values (#142)
ec331f7 
* Previously, only the first mutable store was updated when `FeatureFlagResolver` received a call to set or remove a value
* In this update, the behavior changes: Now all matching stores (i.e. mutable or synchronous mutable) are updated accordingly
* If one of the stores throws an error in the process, this error is caught and kept by the resolver; this is to avoid incomplete operations where an error in a single store prevents updates to the others
* After the remaining stores are updated; the last thrown error is re-thrown by the resolver
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yakovmanshin yakovmanshin

Labels
breaking This issue breaks compatibility with previous versions new New feature or request
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

[#131] Update All Mutable Stores When Setting or Removing Values yakovmanshin/YMFF
1 participant
@yakovmanshin