Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove saveChanges() from feature-flag store protocols #148

Closed
yakovmanshin opened this issue May 12, 2024 · 0 comments · Fixed by #149
Closed

Remove saveChanges() from feature-flag store protocols #148

yakovmanshin opened this issue May 12, 2024 · 0 comments · Fixed by #149
Assignees
@yakovmanshin
Labels
optimization Code optimizations for improved performance
Milestone
v4.0.0

Comments

@yakovmanshin
Copy link
Owner

  • This method is not needed for most feature-flag stores
  • Stores that do need an explicit way to save changes should implement it internally
@yakovmanshin yakovmanshin added the optimization Code optimizations for improved performance label May 12, 2024
@yakovmanshin yakovmanshin added this to the v4.0.0 milestone May 12, 2024
@yakovmanshin yakovmanshin self-assigned this May 12, 2024
@yakovmanshin yakovmanshin mentioned this issue May 12, 2024
Merged
yakovmanshin added a commit that referenced this issue May 12, 2024
@yakovmanshin
[#148] Removed saveChanges() (#149)
90460f3 
* The `saveChanges()` method was not needed for the majority of feature-flag stores
* Only `UserDefaultsStore` had this method implemented
* This change removes the method from protocols for mutable feature-flag stores
* `UserDefaultsStore` synchronizes the changes in `deinit`
* If a custom feature-flag store needs to save changes explicitly, it should implement an internal way to do so
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yakovmanshin yakovmanshin

Labels
optimization Code optimizations for improved performance
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging a pull request may close this issue.

[#148] Removed saveChanges() yakovmanshin/YMFF
1 participant
@yakovmanshin