Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#140] Removed containsValue(forKey:) from Feature-Flag Stores #141

Merged
merged 12 commits into from
May 11, 2024
Merged

[#140] Removed containsValue(forKey:) from Feature-Flag Stores #141

merged 12 commits into from
May 11, 2024

Conversation

yakovmanshin
Copy link
Owner

[Closes #140]

  • Removed the containsValue(forKey: method from protocols for feature-flag stores to prevent conflicts between this method and value(forKey:)
  • Introduced FeatureFlagStoreError which contains two predefined error cases: valueNotFound and typeMismatch; valueNotFound is especially important as it determines the behavior of FeatureFlagResolver
  • Updated the value(forKey:) methods’ return type to Result<Value, FeatureFlagStoreError>
  • Updated FeatureFlagResolver
  • Updated the built-in stores
  • Removed CommonFeatureFlagStoreError
  • Updated tests

@yakovmanshin yakovmanshin added testing Issues related to automated testing optimization Code optimizations for improved performance breaking This issue breaks compatibility with previous versions labels May 11, 2024
@yakovmanshin yakovmanshin added this to the v4.0.0 milestone May 11, 2024
@yakovmanshin yakovmanshin self-assigned this May 11, 2024
@yakovmanshin yakovmanshin enabled auto-merge (squash) May 11, 2024 01:12
@yakovmanshin yakovmanshin merged commit 44376c8 into main May 11, 2024
7 checks passed
@yakovmanshin yakovmanshin deleted the 140-removed-containsValueForKey branch May 11, 2024 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@yakovmanshin yakovmanshin

Labels
breaking This issue breaks compatibility with previous versions optimization Code optimizations for improved performance testing Issues related to automated testing
Projects
None yet
Milestone
v4.0.0
Development

Successfully merging this pull request may close these issues.

Remove the containsValue(forKey:) method from feature-flag stores
1 participant
@yakovmanshin