Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert options, core refactor, more tests #168

Merged
merged 6 commits into from
Jul 9, 2023
Merged

Convert options, core refactor, more tests #168

merged 6 commits into from
Jul 9, 2023

Conversation

mskec
Copy link
Collaborator

@mskec mskec commented May 21, 2023 •
edited

  • Refactored core and removed code duplications
  • Improved types to avoid type casting response. Return type is based on responseType option.
  • Added more tests and assertions

TODO Write tests:

  • assert default options
  • normal with responseType
  • bulk with page range
  • bulk with responseType

@mskec mskec marked this pull request as ready for review July 3, 2023 22:16
yakovmeister
yakovmeister approved these changes Jul 9, 2023
View reviewed changes
Copy link
Owner

@yakovmeister yakovmeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.

@mskec mskec merged commit 877c76e into master Jul 9, 2023
5 of 6 checks passed
@mskec mskec deleted the convert-options branch July 9, 2023 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakovmeister yakovmeister yakovmeister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mskec @yakovmeister