Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disable/enable chat history #664

Open
inliquid opened this issue Apr 18, 2017 · 15 comments
Open

Implement disable/enable chat history #664

inliquid opened this issue Apr 18, 2017 · 15 comments

Comments

@inliquid
Copy link

inliquid commented Apr 18, 2017

I propose to implement it in the same way it is done in native Hangouts web app within chat settings. It's one of the key privacy features of Hangouts. Also there has to be some indicator whether it is enabled or not,

@stale
Copy link

stale bot commented Jul 20, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@skawaii
Copy link

skawaii commented Jul 20, 2017

This is important to me. Please keep it open, all mighty probot!

@stale stale bot removed the inactive label Jul 20, 2017
@stale stale bot added the inactive label Sep 18, 2017
@stale
Copy link

stale bot commented Sep 18, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@skawaii
Copy link

skawaii commented Sep 18, 2017

Oh, almighty stale bot, I beseech you, do not close this ticket. For behold, it is dear unto me.

@stale stale bot removed the inactive label Sep 18, 2017
@averissimo
Copy link
Member

averissimo commented Sep 18, 2017

@skawaii we have a current pull request that enforces the chat_history as the master says.

There is still no option or indicator, but if someone could test it out it would be great!

#769

@skawaii
Copy link

skawaii commented Sep 18, 2017

@averissimo fantastic! I'm happy to test that out for you.

@skawaii
Copy link

skawaii commented Sep 18, 2017

@averissimo I actually don't see a way for me to pull that branch (averissimo:feature-otr). Can you help me out with that?

@averissimo
Copy link
Member

This should do it:

git checkout -b averissimo-feature-otr master
git pull https://github.com/averissimo/yakyak.git feature-otr

@averissimo
Copy link
Member

It should respect the off-the-record status, as well as show messages that history is on/off when the status changes

@skawaii
Copy link

skawaii commented Sep 20, 2017

@averissimo Thanks! I put my comments from testing over on the merge request to help keep things all in one place.

@stale
Copy link

stale bot commented Nov 19, 2017

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Nov 19, 2017
@inliquid
Copy link
Author

Up.

@stale stale bot removed the inactive label Nov 19, 2017
@stale
Copy link

stale bot commented Jan 18, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the inactive label Jan 18, 2018
@stale stale bot removed the inactive label Jan 19, 2018
@averissimo
Copy link
Member

bot is gone from this issue.

I have some code ready for this to respect that status, but does not show immediately that the status of the conversation was changed. I'm going to create a pull request with working code if someone wants to contribute.

@averissimo
Copy link
Member

nevermind about the second paragraph from my last response.

I've updated the pull request #769 and would welcome some comments there :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants