replaces request_status with approved/denied #1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
mikeapp
approved these changes
May 6, 2024
mikeapp
added a commit
that referenced
this pull request
Jul 15, 2024
* adds netid and sub to users table (#929) * adds netid and sub to users table * adds sub to user factory * adds sub_id to params for omniauth --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225172163.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jpengstrom@vpn172022155150.its.yale.internal> * cognito implemented (#932) * cognito implemented * save users netid * remove commented gem * rubocop * adds issuer check * rubocop * comments out specs for another ticket * comment out spec --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225134166.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225168190.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * YCO access now requires a netid * YCO access now requires a netid (#934) * YCO access now requires a netid * rubocop * adds netid to user * adds netid to user * adds netid to user --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * 2653 parent object page owp (#944) * comments out yarn.lock (#930) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Bump @babel/traverse from 7.14.7 to 7.23.2 (#935) Bumps [@babel/traverse](https://github.com/babel/babel/tree/HEAD/packages/babel-traverse) from 7.14.7 to 7.23.2. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.23.2/packages/babel-traverse) --- updated-dependencies: - dependency-name: "@babel/traverse" dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * (MERGE LAST) Add help guide (#936) * help guide section 1 * table of contents * Add anchor tags * (MERGE FIRST) adds help section to landing page (#938) * adds help section to landing page * remove inline css * adds href link --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * adds More Information section to advanced search (#937) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> --------- Co-authored-by: JP Engstrom <jpengstrom@vpn172022159251.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jp@scientist.com> * media queries for new landing content (#939) Co-authored-by: JP Engstrom <jpengstrom@vpn172022125028.its.yale.internal> * body text set to mallory-medium (#940) Co-authored-by: JP Engstrom <jpengstrom@vpn172022112006.its.yale.internal> * Bump postcss from 8.2.13 to 8.4.31 (#933) Bumps [postcss](https://github.com/postcss/postcss) from 8.2.13 to 8.4.31. - [Release notes](https://github.com/postcss/postcss/releases) - [Changelog](https://github.com/postcss/postcss/blob/main/CHANGELOG.md) - [Commits](postcss/postcss@8.2.13...8.4.31) --- updated-dependencies: - dependency-name: postcss dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Format morris record url (#906) (#941) * format morris record url * custom morris_link for morris records * rubocop --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225157138.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * new font and centered images (#942) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * conditionals for signed in users * system specs for owp access * rubocop * show page spec rework to not visit catalog in before block * toggle tools based on owp access * refactor output message to view * adds OwP to digital object check * adds try to permisson loop * adds OwP check to logged in no access * remove unneeded conditional * return nil if no current_user present * Revert "Merge branch 'main' into 2653_ParentObjectPageOwP" This reverts commit 52b9c48, reversing changes made to a9a850e. * refactor visibility check to use method * Revert to original * update specs for tools partial * update specs --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kait Sewell <36549923+K8Sewell@users.noreply.github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022159251.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn172022125028.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn172022112006.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225157138.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225132108.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225130112.its.yale.internal> Co-authored-by: K8Sewell <kait@notch8.com> Co-authored-by: JP Engstrom <jpengstrom@vpn1722517119.its.yale.internal> * Address failing smoke tests (#946) * Add addressable gem and pin psych * Explicitly require addressable gem * Disable flaky spec (#947) * Add addressable gem and pin psych * Explicitly require addressable gem * Disable flaky spec * Adds request form (#948) * request form * styled metadata block * Eliminate duplicate method and add cancel link * styles form * nil checks * Add guards for labels and values and make fields required * Add guard for having a current user * Add guards and rubocop * Add guard for when object is not owp * catchup * Update attributes * controller params and model attributes * Add handling for responses from mgmt * Add error handling and rubocop * Add period --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jpengstrom@vpn172022152156.its.yale.internal> * Adds management calls for confirmation page (#949) * Pull from management to populate confirmation page * Rubocop and replacing mgmt host var * Adds tests and modifies css * working commit * Modify logic and update spec * 2657 pending request notification (#952) * adds pending request notification to showpage * rubocop * adds t/f returns for pending_request * rubocop * clean up stub request --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225141189.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * adds nil check to request_status (#956) Co-authored-by: JP Engstrom <jpengstrom@vpn17225142207.its.yale.internal> * Terms and Conditions (#959) Co-authored-by: JP Engstrom <jpengstrom@vpn17225141224.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * 2654 terms bug (#961) * alter terms route * fixes auth token and missing request user error --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225169116.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Converts cas auth in specs to openid connect (#962) * Adds bookmark functionality (#964) * Enables bookmarks * Bookmarks header (#910) * Update bookmark icon (#902) * Replace apple icon with yale icon * Make links relative * add facet field so search builder works with iiif_search (#904) * Resize to 120x120 to match size specified in the link element. (#905) * edit header dropdown (#908) Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> * adds bookmarks nav link to header * header spec * adds li to bookmarks link --------- Co-authored-by: JP Engstrom <jpengstrom@vpn172022123085.its.yale.internal> Co-authored-by: Kait Sewell <36549923+K8Sewell@users.noreply.github.com> Co-authored-by: martinlovell <32851993+martinlovell@users.noreply.github.com> Co-authored-by: mikeapp <michael.appleby@yale.edu> Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Clear bookmarks button (#911) * Update bookmark icon (#902) * Replace apple icon with yale icon * Make links relative * add facet field so search builder works with iiif_search (#904) * Resize to 120x120 to match size specified in the link element. (#905) * edit header dropdown (#908) Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> * restyled clear bookmarks button * rename to Clear All Bookmarks * reword confirmation message --------- Co-authored-by: JP Engstrom <jpengstrom@vpn172022123085.its.yale.internal> Co-authored-by: Kait Sewell <36549923+K8Sewell@users.noreply.github.com> Co-authored-by: martinlovell <32851993+martinlovell@users.noreply.github.com> Co-authored-by: mikeapp <michael.appleby@yale.edu> Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Aligns cite button (#912) * Update bookmark icon (#902) * Replace apple icon with yale icon * Make links relative * add facet field so search builder works with iiif_search (#904) * Resize to 120x120 to match size specified in the link element. (#905) * edit header dropdown (#908) Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> * 2543 add contributor field (#909) * adds contributor information to metadata description block * filter for aspace --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> * Bump semver from 5.7.1 to 5.7.2 (#907) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * adds spacing between Cite button and gallery thumbnails --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022123085.its.yale.internal> Co-authored-by: Kait Sewell <36549923+K8Sewell@users.noreply.github.com> Co-authored-by: martinlovell <32851993+martinlovell@users.noreply.github.com> Co-authored-by: mikeapp <michael.appleby@yale.edu> Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022148020.its.yale.internal> * bookmark checkbox alignment (#914) * Update bookmark icon (#902) * Replace apple icon with yale icon * Make links relative * add facet field so search builder works with iiif_search (#904) * Resize to 120x120 to match size specified in the link element. (#905) * edit header dropdown (#908) Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> * 2543 add contributor field (#909) * adds contributor information to metadata description block * filter for aspace --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> * Bump semver from 5.7.1 to 5.7.2 (#907) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * bookmark checkbox realigned on search results --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022123085.its.yale.internal> Co-authored-by: Kait Sewell <36549923+K8Sewell@users.noreply.github.com> Co-authored-by: martinlovell <32851993+martinlovell@users.noreply.github.com> Co-authored-by: mikeapp <michael.appleby@yale.edu> Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022148020.its.yale.internal> * Changes font tag (#915) * Override to decrease font tag * Makes bookmarks page pass accessibility test (#916) * 2567 undo typo (#919) * Update bookmark icon (#902) * Replace apple icon with yale icon * Make links relative * add facet field so search builder works with iiif_search (#904) * Resize to 120x120 to match size specified in the link element. (#905) * edit header dropdown (#908) Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> * 2543 add contributor field (#909) * adds contributor information to metadata description block * filter for aspace --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> * Bump semver from 5.7.1 to 5.7.2 (#907) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * undo typo --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022123085.its.yale.internal> Co-authored-by: Kait Sewell <36549923+K8Sewell@users.noreply.github.com> Co-authored-by: martinlovell <32851993+martinlovell@users.noreply.github.com> Co-authored-by: mikeapp <michael.appleby@yale.edu> Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022148020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225163155.its.yale.internal> * Alignment bug (#920) * Update bookmark icon (#902) * Replace apple icon with yale icon * Make links relative * add facet field so search builder works with iiif_search (#904) * Resize to 120x120 to match size specified in the link element. (#905) * edit header dropdown (#908) Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> * 2543 add contributor field (#909) * adds contributor information to metadata description block * filter for aspace --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> * Bump semver from 5.7.1 to 5.7.2 (#907) Bumps [semver](https://github.com/npm/node-semver) from 5.7.1 to 5.7.2. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/v5.7.2/CHANGELOG.md) - [Commits](npm/node-semver@v5.7.1...v5.7.2) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * realign bookmark checkboxes --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022123085.its.yale.internal> Co-authored-by: Kait Sewell <36549923+K8Sewell@users.noreply.github.com> Co-authored-by: martinlovell <32851993+martinlovell@users.noreply.github.com> Co-authored-by: mikeapp <michael.appleby@yale.edu> Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022148020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225163155.its.yale.internal> * Add bookmark functionality * Update user attributes for test --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: JP Engstrom <jp@scientist.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022123085.its.yale.internal> Co-authored-by: martinlovell <32851993+martinlovell@users.noreply.github.com> Co-authored-by: mikeapp <michael.appleby@yale.edu> Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022148020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225163155.its.yale.internal> * Create fallback for when terms are nil (#965) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Resolve merge conflicts (#966) * Fix login button in notification message (#969) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Adds user permission requests table (#968) * Bump omniauth to previous version (#972) Co-authored-by: JP Engstrom <jpengstrom@vpn17225171170.its.yale.internal> * Style owp explanation (#974) * Update styles for explaination text * Put back env var * Move style to default section * Update button to link (#980) * Add terms and conditions to show page (#984) * Add terms and conditions to show page * Remove console log * Fix broken spec * Bookmark Gallery View (#986) * moves bookmark checkbox above the image thumbnail on gallery view * updates show page system spec --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Confirm that OwP full text in search results follows access permissions (#988) * Add test to confirm behavior * Fix up specs * Sets up owp admin access (#990) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Revert "Sets up owp admin access (#990)" (#991) This reverts commit 0cb2dfe. * fixes search bug with owp admin/approver access (#992) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Hide OwP Full Text (#994) --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * adds spec coverage for OwP fulltext annotation (#995) * adds spec coverage for OwP fulltext annotation * adds OwP parent * comma typo --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Specs for IIIF Search OwP (#996) * adds specs to test against OwP iiif searches * rubocop * changes child_oid * expect unauthorized for OwP IIIF search * removes file that was accidentally added --------- Co-authored-by: JP Engstrom <jpengstrom@vpn17225158166.its.yale.internal> * Update Full Text label wording (#998) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * OwP Thumbnail (#1001) * adds placeholder image thumbnail for OwP objects * rubocop --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * adds OwP language to help guide (#1000) Co-authored-by: JP Engstrom <jpengstrom@vpn17225170126.its.yale.internal> * OwP Fulltext Access (#999) * adds api calls for fulltext access * refactor and specs * remove logger * revert spec * owp fulltext specs * adds different owp object * adds specs to full_text search spec * adds fulltext_wstsim * remove unneeded spec * adds parent_ssi to child * adds more solr parameters to owp child * rubocop * test different fulltext * revert test change * comment out spec * Comment in field and expectation * mark spec pending * refactor fulltext credentials call * rubocop * adds return if oid not present * changes return to false --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jpengstrom@vpn17225170126.its.yale.internal> Co-authored-by: K8Sewell <kait@notch8.com> Co-authored-by: JP Engstrom <jpengstrom@vpn17225174210.its.yale.internal> * replaces request_status with approved/denied (#1002) * replaces request_status with approved/denied * changes request_status to approved on user * updating specs with new request_status * updates more specs --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * adds permission_requests link to header and changes bookmarks wording (#1005) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * adds /permission_requests link to pending request message (#1004) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Update bookmarks language (#1007) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Updates to requests page (#1006) * removes bookmarks button and updates access wording * updates spec * updates spec --------- Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * updates bookmarks to saved items (#1009) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Mark a few specs as pending * updates confirmation messages (#1014) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * fixes permission requests table sorting (#1016) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * disable bookmarks for guests (#1019) Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> * Resolve Confirmation Page bug (#1026) Co-authored-by: JP Engstrom <jpengstrom@vpn172022156212.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: JP Engstrom <jp@scientist.com> Co-authored-by: JP Engstrom <jpengstrom@vpn17225172163.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@macbook-pro.lan> Co-authored-by: JP Engstrom <jpengstrom@vpn172022155150.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225134166.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225168190.its.yale.internal> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: JP Engstrom <jpengstrom@vpn172022159251.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn172022125028.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn172022112006.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225157138.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225132108.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225130112.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn1722517119.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn172022152156.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225141189.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225142207.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225141224.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225169116.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn172022123085.its.yale.internal> Co-authored-by: martinlovell <32851993+martinlovell@users.noreply.github.com> Co-authored-by: mikeapp <michael.appleby@yale.edu> Co-authored-by: JP Engstrom <jpengstrom@vpn172022146020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225159106.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn172022148020.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225163155.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225171170.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225158166.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225170126.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn17225174210.its.yale.internal> Co-authored-by: JP Engstrom <jpengstrom@vpn172022156212.its.yale.internal>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces true/false request_status with Approved/Denied