-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check_rate_limit can fail if getStatus does not return any results #117
Labels
bug
Something isn't working
Comments
yaleman
added a commit
that referenced
this issue
Dec 27, 2021
@cheops I've updated the package to 0.0.6 in pypi with the suggested fixes, thanks! |
Ok, I broke 0.0.6 on pypi, something about how I built the package - I'll fix it shortly in 0.0.7 |
0.0.7's out and works 😄 |
works fine! |
Thanks again for the report 👍🏻 |
yaleman
added a commit
that referenced
this issue
Dec 30, 2021
* cleaning up docs generation * getstatus works * adding more tests * closes #117, fix check_rate_limit * updated package to 0.0.6 * moving to flit for build * removing pipfile * removing old scripts * updated for flit build * updated README * removing setup.py * fixing typo per @cheops PR * fixing README link * fixing pyproject per @cheops PR * fixing some code smells * removing travis logo * fixing handling of errors * working around CI * added missing flit * added missing flit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
check_rate_limit uses the url = "https://pvoutput.org/service/r2/getstatus.jsp" (and also wrongly uses the default _call method=requests.post)
but this can return an error, from the documentation:
the Get System Service with the method requests.get seems a safer bet
The text was updated successfully, but these errors were encountered: