Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

28 create step page #35

Merged
merged 5 commits into from
Jul 14, 2021
Merged

28 create step page #35

merged 5 commits into from
Jul 14, 2021

Conversation

ashatat
Copy link
Contributor

@ashatat ashatat commented Jul 13, 2021

Issues this PR relates to

Fixes #28

=======

NOTE: REMEMBER NOT TO REVIEW UNLESS ALL ACCEPTANCE CRITERIA HAS BEEN TICKED OFF


Any info the reviewer needs to know to test

@fadeomar If you don't mind finishing up the style here, it's a bit tricky for me

Any info the team needs to consider before merged into development

e.g. Will a database need to be rebuilt (and is this ok if existing data), add env vars


Quick Pull Request Checklist

Please make sure you ensure the following has been done before marking your PR as awaiting-review. For full checklist and process review, please refer to Process Guide (#8)

  • Branch is up to date with develop
  • Project runs
  • You can download and install locally, and run the project locally
  • All existing and new features run without bugs
  • Checked that features/design works across all agreed browsers + devices
  • The new work has been checked with Axe accessibility checker and doesn't throw significant errors
  • Linter is used
  • Code is consistent with agreed team style
  • Naming of files is consistent with project
  • Tests all pass
  • No console logs

@fadeomar fadeomar merged commit 00096c5 into develop Jul 14, 2021
@fadeomar fadeomar deleted the 28-create-step-page branch July 14, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Step Page
2 participants