Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.06 build problems with the new --keep-locs as a default #552

Closed
dbuenzli opened this issue Nov 10, 2017 · 3 comments
Closed

4.06 build problems with the new --keep-locs as a default #552

dbuenzli opened this issue Nov 10, 2017 · 3 comments

Comments

@dbuenzli
Copy link
Contributor

dbuenzli commented Nov 10, 2017

In 4.06 --keep-locs became a default in the compiler driver. This means that the various foreign.mli files compiled and installed no longer sport the same digest (I do think that the wrong thing is being digested here but that's another question).

The fix should be to simply compile the various foreign.mli with the --no-keep-locs option. I think this is the problem witnessed in dbuenzli/tsdl#44

@ghost
Copy link

ghost commented Nov 10, 2017

Note that even though dbuenzli/tsdl#44 is marked as closed, the issue still stands.

@yallop
Copy link
Owner

yallop commented Nov 18, 2017

There's a fix in #553.

trefis added a commit to janestreet/opam-repository that referenced this issue Nov 21, 2017
trefis added a commit to janestreet/opam-repository that referenced this issue Nov 21, 2017
@dbuenzli
Copy link
Contributor Author

Thanks Jeremy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants