work around missing math functions on bsd platforms #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will fix yallop#502 and a related problem on netbsd. I've intentionally not implemented any kind of feature detection. It's tricky. The header definitions are available and the functions are understood by gcc/clang, although they are not implemented by the c standard library. But gcc will generate opcode for them under certain conditions...
|
Thanks! I don't have an easy way to test this, but it looks reasonable. We're starting to accumulate a few platform tests around the code. I think in the medium term it'd be useful to collect all these together in a single header (and in the longer term perhaps replace a few system-name macros with configure-time feature detection). See #506. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for #502 and a related problem on netbsd.
I've intentionally not implemented any kind of feature detection. It's tricky. The header definitions are available and the functions are understood by gcc/clang, although they are not implemented by the c standard library. But gcc will generate opcode for them under certain conditions...
Openbsd seems to have implemented all necessary functions. However their libffi package is currently broken (their newest kernel introduced something similar to grsecurity's mprotect. They've tried to patch libffi accordingly, but it doesn't seem to work as intended)