feat(breadcrumbs): added ellipsis #1301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
==========================================
+ Coverage 91.96% 91.97% +0.01%
==========================================
Files 405 405
Lines 61432 61470 +38
Branches 4060 4064 +4
==========================================
+ Hits 56496 56540 +44
+ Misses 4928 4922 -6
Partials 8 8
|
taroj1205
reviewed
Apr 28, 2024
There was a problem hiding this comment.
Thanks for the PR.
Could you fix the spelling error in line 29 and 45 in test?
propertie -> property
We don't need template literals if interpolation and special-character handling are not needed.
Line 21 in breadcrumb.tsx
name: `BreadcrumbContext`,
should be name: "BreadcrumbContext",
taroj1205
approved these changes
Apr 28, 2024
hirotomoyamada
approved these changes
Apr 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #987
Description
made it possible to select
BreadcrumbEllipsis(ellipsis).New behavior
The places where ellipsis is used will display as
•••instead of textIs this a breaking change (Yes/No):
No