New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add title for withFallback-avatar-svg #1304
Add title for withFallback-avatar-svg #1304
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1304 +/- ##
==========================================
- Coverage 91.98% 91.96% -0.02%
==========================================
Files 405 405
Lines 61492 61431 -61
Branches 4065 4059 -6
==========================================
- Hits 56562 56495 -67
- Misses 4922 4928 +6
Partials 8 8
|
@hirotomoyamada Please review again! |
Thanks! |
Closes #1244
Description
Add title for withFallback-avatar-svg
Current behavior (updates)
There is no alternative text in elements. and it violates a11y.
New behavior
Added a title to the svg element to avoid violating a11y.
Is this a breaking change (Yes/No): No
Additional Information
N/A