Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title for withFallback-avatar-svg #1304

Merged
merged 4 commits into from Apr 29, 2024

Conversation

38Koo
Copy link
Contributor

@38Koo 38Koo commented Apr 27, 2024

Closes #1244

Description

Add title for withFallback-avatar-svg

Current behavior (updates)

There is no alternative text in elements. and it violates a11y.

New behavior

Added a title to the svg element to avoid violating a11y.

Is this a breaking change (Yes/No): No

Additional Information

N/A

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.96%. Comparing base (6c91ba9) to head (64120a4).
Report is 1 commits behind head on main.

❗ Current head 64120a4 differs from pull request most recent head 953749a. Consider uploading reports for the commit 953749a to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1304      +/-   ##
==========================================
- Coverage   91.98%   91.96%   -0.02%     
==========================================
  Files         405      405              
  Lines       61492    61431      -61     
  Branches     4065     4059       -6     
==========================================
- Hits        56562    56495      -67     
- Misses       4922     4928       +6     
  Partials        8        8              
Files Coverage Δ
packages/components/avatar/src/avatar-icon.tsx 100.00% <100.00%> (ø)

... and 9 files with indirect coverage changes

@38Koo
Copy link
Contributor Author

38Koo commented Apr 29, 2024

@hirotomoyamada
Thank you for your review.
I don't know the rules for re-push, so it would be helpful if you could let me know if I made a mistake.

Please review again!

@hirotomoyamada
Copy link
Member

Thanks!

@hirotomoyamada hirotomoyamada merged commit 960304f into yamada-ui:main Apr 29, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance a11y for Avatar
3 participants