Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated framer-motion #2126

Merged
merged 9 commits into from
Jun 20, 2024
Merged

Updated framer-motion #2126

merged 9 commits into from
Jun 20, 2024

Conversation

hirotomoyamada
Copy link
Member

Description

Updated dependencies.

Is this a breaking change (Yes/No):

No

Copy link

vercel bot commented Jun 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
yamada-ui ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 20, 2024 8:19am

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 99.04762% with 3 lines in your changes missing coverage. Please review.

Project coverage is 97.63%. Comparing base (8d4f75a) to head (af57bae).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main    #2126    +/-   ##
========================================
  Coverage   97.62%   97.63%            
========================================
  Files        1884     1884            
  Lines       94750    94987   +237     
  Branches     4894     4894            
========================================
+ Hits        92503    92740   +237     
  Misses       2240     2240            
  Partials        7        7            
Files Coverage Δ
packages/components/modal/src/dialog.tsx 98.34% <100.00%> (ø)
packages/components/motion/src/index.ts 100.00% <100.00%> (ø)
packages/components/motion/src/motion.types.ts 100.00% <100.00%> (ø)
packages/components/reorder/src/reorder-item.tsx 96.63% <100.00%> (+0.63%) ⬆️
packages/core/src/css/css.types.ts 100.00% <100.00%> (ø)
packages/utils/src/index.types.ts 100.00% <100.00%> (ø)
packages/components/reorder/src/reorder.tsx 86.50% <92.30%> (+1.17%) ⬆️

@hirotomoyamada
Copy link
Member Author

@108yen @kurakke @taroj1205 @hirayamahiroto

Fixed tests.

Copy link
Member

@108yen 108yen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not include multiple assertions inside waitFor. Please put only the first one inside waitFor.
If you want to make getxxx asynchronous, use findxxx.

Are you sure that forwardRef is imported from react and not @yamada-ui/core?

packages/components/modal/src/dialog.tsx Show resolved Hide resolved
@hirotomoyamada
Copy link
Member Author

@108yen

This time, the forwardRef will be imported from React. The reason is that we want to genericize the component type.

@hirotomoyamada
Copy link
Member Author

@108yen

Fixed tests.

108yen
108yen previously approved these changes Jun 19, 2024
kurakke
kurakke previously approved these changes Jun 19, 2024
taroj1205
taroj1205 previously approved these changes Jun 19, 2024
@hirotomoyamada hirotomoyamada merged commit e0fea83 into main Jun 20, 2024
7 checks passed
@hirotomoyamada hirotomoyamada deleted the build/framer-motion branch June 20, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants