Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make clap an optional dependency when using jql as a library #113

Closed
jqnatividad opened this issue Dec 16, 2021 · 3 comments · Fixed by #114
Closed

Make clap an optional dependency when using jql as a library #113

jqnatividad opened this issue Dec 16, 2021 · 3 comments · Fixed by #114
Labels
enhancement New feature or request

Comments

@jqnatividad
Copy link
Contributor

I'm currently using jql as a library for which clap (and maybe, even colored_json) is not required.

Can these dependencies be marked optional that are only included when perhaps a non-default CLI feature is used?

@yamafaktory yamafaktory added the enhancement New feature or request label Dec 17, 2021
@yamafaktory
Copy link
Owner

Hi @jqnatividad !

You might be the first one doing that. The split between lib/bin was primarily done for testing purposes. I'll take a look at it as it might be feasible as per https://doc.rust-lang.org/cargo/reference/specifying-dependencies.html.

@yamafaktory
Copy link
Owner

Hi @jqnatividad,

I've released a new version which should include a workaround (https://crates.io/crates/jql/3.0.6). Hope it will help!

@jqnatividad
Copy link
Contributor Author

Hi @yamafaktory !
Thanks for the quick turn-around!
I can confirm that it works for qsv.

I just changed my cargo.toml accordingly:
jql = { version = "3.0.6", default-features = false }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants