Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic Provider layout generation #12

Merged
merged 2 commits into from Aug 8, 2019

Conversation

alexandrius
Copy link
Contributor

Solves #11 and possibly #9

@yamalight
Copy link
Owner

yamalight commented Aug 7, 2019

A few small requests - could you please:

  • add a test case for multiple stores
  • make sure eslint passes (I should probably set it up in npm scripts)
  • add note to readme that explains separate contexts for separate stores

@alexandrius
Copy link
Contributor Author

@yamalight Sorry I'm not eslint expert could you help me with this error:

Oops! Something went wrong! :(

ESLint: 6.1.0.

ESLint couldn't find the config "standard" to extend from. Please check that the name of the config is correct.

The config "standard" was referenced from the config file in "/Users/alex/Documents/Development/ReactNative/outstated/.eslintrc".

If you still have problems, please stop by https://gitter.im/eslint/eslint to chat with the team.

@yamalight
Copy link
Owner

Ah, right, I forgot there was whole eslint 6.x upgrade issue here as well. OK, disregard eslint, I can do that myself after merge :)

@yamalight
Copy link
Owner

Looks good, thanks! Will do a release later today

@yamalight yamalight merged commit 57dac4b into yamalight:master Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants