Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crafting/Update Recipes #94

Merged
merged 6 commits into from
Oct 9, 2020
Merged

Crafting/Update Recipes #94

merged 6 commits into from
Oct 9, 2020

Conversation

Macroft
Copy link
Contributor

@Macroft Macroft commented Oct 6, 2020

  • updated recipes for metalwork, electronics, refiner, and assembler M
  • Batch sizes were off on some stuff. (Went with industry sizes, as it is default and different skills apply to nano)
  • A few recipes were fixed.
  • Other fixes were applied when noticed (mass,tier,etc) but were not the primary focus. inputs were

@MitoG
Copy link
Contributor

MitoG commented Oct 7, 2020

just a thought, since the base recipes and output quantities haven't really changed, could it maybe be more usefull to introduce a new field to serve as a batch mutliplier ?

@Macroft
Copy link
Contributor Author

Macroft commented Oct 8, 2020

  • The point of updating the batch size is to correctly calculate the number of batches. It doesn't really impact using the calculator for continuous operations because it happens to be a straightforward multiplication this time, it does make a difference for the user that is looking to make one of something.

  • Of course if you are talking about having different multipliers chosen based on machine choice in detailed view, that could be useful if they are going to keep changing recipes and keep the trend of simple multiplications. if that change is implemented it will be just as easy to put a .5 instead of a 2 at that time.

@Allen-Tainia
Copy link
Collaborator

merging for now, will consider doing the multiplication field if they do ever change the batch sizes on a large scale again

@Allen-Tainia Allen-Tainia merged commit 33596f4 into yamamushi:dev Oct 9, 2020
@Allen-Tainia Allen-Tainia linked an issue Oct 9, 2020 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Concrete Recipe is incorrect
3 participants