Fix delay when stopping the docker container #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the most efficient way to block the go-routine of exiting is to simply
select{} on nothing.
with EXEC syntax. This change was actually done because of the problem that when using ENTRYPOINT with shell syntax, in the Docker container first a shell command is launched which in turn executes the go command afterwards. The problem with that is when stopping the container the shell command would receive the SIGTERM signal and it does not pass it somehow to the running go-process. This means the container does not exit after receiving the SIGTERM but docker will invoke, usually after 10 seconds, a SIGKILL. This is somewhat unclean.
|
As a minor side-note: at the moment the environment variables are preferred over command line flags. I think this is a bit unintuitive. Usually it is the other way around, but I didn't want to include this in my PR as it possibly would break things. What do you think about this? |
|
Hi @marco-jantke, |
|
Hehe great, thanks for merging and publishing the image so quickly :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yaman,
while setting up integration tests for my project I stumbled over your repository and found it quite useful and would like to use it there. Anyway I had small problems with getting it to work, as the docker image does not listen properly to the SIGTERM signal, because it was using the shell form of the ENTRYPOINT syntax. Here is a quite good article how docker stops and why it doesn't work properly with this shell form.
As the setup and the go version 1.4.2 is coming to age, I changed the docker setup to the version 1.8 in the way it is recommended on the golang docker image here(Section: Start a Go instance in your app). To get this working I had to extend the code a bit, so that it can read also the
protofrom the environment and did a minor optimisation with the for-loop.This way the change is completely compatible, the same docker commands work and from the command line nothing changed. I hope you like the change and you are up to merging this. I would be very happy when you can publish the new version on dockerhub as well. This would make it most easy for me to integrate it in my integration setup.
Let me know about feedback :)