Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Definition of sigma_y and Tait-Bryan angles #50

Closed
sangallidavide opened this issue Jun 26, 2023 · 3 comments
Closed

Definition of sigma_y and Tait-Bryan angles #50

sangallidavide opened this issue Jun 26, 2023 · 3 comments
Assignees

Comments

@sangallidavide
Copy link
Member

sangallidavide commented Jun 26, 2023

Reported by @muralidhar-nalabothula :
https://www.yambo-code.eu/forum/viewtopic.php?p=12955#p12955

The sigma_y matrix defined in "yambo/src/modules/mod_D_lattice.F" is not correct.
As Fortran in column major, reshaping [1,2,3,4] will give ([[1 3],[2 4]])

So the matrix is currently defined as -sigma_y(actual). I can see that in one of the Tait-Bryan angles (beta) defined in "yambo/src/setup/build_spin_sop.F" lacks minus sign. I guess the minus was removed to compensate this. When rotating spinors wave functions with time reversal symmetry, it picks up an additional phase of -1 (which does not effect the results due to gauge arbitrary ness). I also see some other instances where sigma_y is used.

@sangallidavide sangallidavide self-assigned this Jun 26, 2023
@sangallidavide sangallidavide changed the title Possible issue reported by a user in the forum. Definition of sigma_y and Tait-Bryan angles Jun 26, 2023
sangallidavide added a commit to sangallidavide/yambo that referenced this issue Jul 10, 2023
MODIFIED *  include/version/version.m4 modules/mod_D_lattice.F setup/build_spin_sop.F

Bugs:
- addressing issue yambo-code#50

Patch sent by:  Davide Sangalli <davide.sangalli@gmail.com>
@sangallidavide
Copy link
Member Author

I pushed the change in branch https://github.com/sangallidavide/yambo/tree/fixes/bse-finite-q

@muralidhar-nalabothula
Copy link
Contributor

Looks fine for me. I checked for WSe2 (with SOC) and results did not change.

sangallidavide added a commit to sangallidavide/yambo that referenced this issue Jul 25, 2023
MODIFIED *  include/version/version.m4 modules/mod_D_lattice.F setup/build_spin_sop.F

Bugs:
- addressing issue yambo-code#50

Patch sent by:  Davide Sangalli <davide.sangalli@gmail.com>
sangallidavide added a commit that referenced this issue Jul 25, 2023
MODIFIED *  include/version/version.m4 modules/mod_D_lattice.F setup/build_spin_sop.F

Bugs:
- addressing issue #50

Patch sent by:  Davide Sangalli <davide.sangalli@gmail.com>
sangallidavide added a commit that referenced this issue Jul 25, 2023
MODIFIED *  include/version/version.m4 modules/mod_D_lattice.F setup/build_spin_sop.F

Bugs:
- addressing issue #50

Patch sent by:  Davide Sangalli <davide.sangalli@gmail.com>
sangallidavide added a commit that referenced this issue Jul 25, 2023
MODIFIED *  include/version/version.m4 modules/mod_D_lattice.F setup/build_spin_sop.F

Bugs:
- addressing issue #50

Patch sent by:  Davide Sangalli <davide.sangalli@gmail.com>
@sangallidavide
Copy link
Member Author

Fixes entered in the releases and in the branches.
I close the issue

P.S.: @muralidhar-nalabothula I have the impression that this fixes solves a long-standing issue for BSE with SOC at finite momentum. So the results for WSe2 should be the same at q=0, but different at finite q after this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants