-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix -Wformat compilation errors in tests #36
Conversation
@sigmavirus24, could you explain how you got these warnings, or point to a I applied your patch and ran See: https://gist.github.com/anonymous/dbebcf632b91a54c4f25c7ceb79c4fcd |
Using the dockerfiles in tree, I ran |
And if you look at Semaphore you'll see that it also doesn't have the warnings you've found. I want to slowly start adding more flags to our Makefile though until we have -Wall covered and then we can enable -Werror so that we prevent regression of them. |
1c2e471
to
bce6091
Compare
@ingydotnet I updated this. I can't find any format related warnings now on Ubuntu or macOS/OSX. |
@sigmavirus24, I'm still getting all the warnings on OSX See: https://gist.github.com/693103baa4949eb2187810138a79d94b Linux make and make test is warning free, but is also that way on Confused. |
There were several warnings generated by formatting errors in the tests, this corrects the format strings and silences the warnings.
This should catch the problems Ingy saw locally
1431cc9
to
81378c1
Compare
Using your gist, I corrected the last of the |
Looks good to me. Applied, pushed, thanks. |
There were several warnings generated by formatting errors in the tests,
this corrects the format strings and silences the warnings.