Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix -Wformat compilation errors in tests #36

Closed
wants to merge 2 commits into from

Conversation

sigmavirus24
Copy link
Contributor

There were several warnings generated by formatting errors in the tests,
this corrects the format strings and silences the warnings.

@ingydotnet
Copy link
Member

@sigmavirus24, could you explain how you got these warnings, or point to a
system showing them?

I applied your patch and ran make test but still got the same warnings (for
both make and `make test) as before the patch.

See: https://gist.github.com/anonymous/dbebcf632b91a54c4f25c7ceb79c4fcd

@sigmavirus24
Copy link
Contributor Author

Using the dockerfiles in tree, I ran make clean && make after building a second time. Looks like you're running on OSX. I'll test that out tonight.

@sigmavirus24
Copy link
Contributor Author

And if you look at Semaphore you'll see that it also doesn't have the warnings you've found. I want to slowly start adding more flags to our Makefile though until we have -Wall covered and then we can enable -Werror so that we prevent regression of them.

@sigmavirus24
Copy link
Contributor Author

@ingydotnet I updated this. I can't find any format related warnings now on Ubuntu or macOS/OSX.

@ingydotnet
Copy link
Member

@sigmavirus24, I'm still getting all the warnings on OSX

See: https://gist.github.com/693103baa4949eb2187810138a79d94b

Linux make and make test is warning free, but is also that way on
origin/master.

Confused.

There were several warnings generated by formatting errors in the tests,
this corrects the format strings and silences the warnings.
This should catch the problems Ingy saw locally
@sigmavirus24
Copy link
Contributor Author

Using your gist, I corrected the last of the -Wformat errors that either of us seem to be able to find.

@ingydotnet
Copy link
Member

Looks good to me. Applied, pushed, thanks.

@ingydotnet ingydotnet closed this Dec 17, 2016
@sigmavirus24 sigmavirus24 deleted the fix-compilation branch December 23, 2016 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants