Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Undefined PTRDIFF_MAX on HP-UX #77

Merged
merged 1 commit into from
Dec 23, 2017
Merged

Undefined PTRDIFF_MAX on HP-UX #77

merged 1 commit into from
Dec 23, 2017

Conversation

perlpunk
Copy link
Member

@perlpunk perlpunk commented Dec 2, 2017

@Tux reported this on IRC:

reader.c: In function 'yaml_parser_update_buffer':
reader.c:463:27: error: 'PTRDIFF_MAX' undeclared (first use in this function)
reader.c:463:27: note: each undeclared identifier is reported only once for each function it appears in

HP-UX 11.23 ia64 5.24.1/64all/longdouble/gcc-4.6.0

@perlpunk
Copy link
Member Author

perlpunk commented Dec 2, 2017

@Tux gave me a fix for this. I created a Pull Request from that.

@sigmavirus24
Copy link
Contributor

Would be wonderful to be able to test this. Sadly that's untenable.

@perlpunk
Define PTRDIFF_MAX if it's not in stdint.h
5672b16 
Seems to be the case on HP-UX
@perlpunk perlpunk merged commit 5672b16 into master Dec 23, 2017
@perlpunk
Copy link
Member Author

Merged. Thanks @Tux!

@perlpunk perlpunk deleted the perlpunk/hp-ux branch December 23, 2017 01:00
@ingydotnet
Copy link
Member

@perlpunk please don't add derogatory comments like this into the code:

#ifndef PTRDIFF_MAX /* gcc on HP-UX sucks */

I'll remove it as part of #16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigmavirus24 sigmavirus24 sigmavirus24 approved these changes

@ingydotnet ingydotnet Awaiting requested review from ingydotnet

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@perlpunk @sigmavirus24 @ingydotnet