Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support unicode literals over codepoint 0xffff #65

Closed
wants to merge 1 commit into from

Conversation

@adamchainz
Copy link

@adamchainz adamchainz commented May 16, 2017

Fixes #25. Rebase and tidy up of #63.

@adamchainz adamchainz force-pushed the issue_25_support_unicode branch from 421c9b3 to e7272cc May 16, 2017
@adamchainz
Copy link
Author

@adamchainz adamchainz commented May 16, 2017

I took #63, squashed the commits and removed the diff noise that I noted there. As I'm not a maintainer I couldn't puh to @peterkmurphy 's branch.

Ping @sigmavirus24

Loading

@adrienverge
Copy link

@adrienverge adrienverge commented Jun 6, 2017

Looks like a good enhancement!

@sigmavirus24 what do you think of this?

Loading

@timja
Copy link

@timja timja commented Jul 31, 2017

@sigmavirus24 any chance of reviewing this change?

Loading

@adamchainz
Copy link
Author

@adamchainz adamchainz commented Jul 31, 2017

I've solved a riddle from http://www.coglib.com/~icordasc/index.html#resume and directly emailed @sigmavirus24 with regards to this

Loading

@sigmavirus24
Copy link
Contributor

@sigmavirus24 sigmavirus24 commented Aug 8, 2017

This fix has been merged in the original pull request. Cheers

Loading

@ingydotnet ingydotnet added this to PRs and Notes to Consider in 5.2 Release Mar 14, 2019
@ingydotnet ingydotnet removed this from PRs and Notes to Consider in 5.2 Release Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants