Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix remove unit assignments #136

Merged
merged 6 commits into from Jul 29, 2021
Merged

Conversation

jvanhoefer
Copy link
Member

No description provided.

@jvanhoefer
Copy link
Member Author

@dilpath @yannikschaelte

This would be my approach to the problem described in PR #135. What do you think about that? :)

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2021

Codecov Report

Merging #136 (47a1f56) into develop (139300c) will decrease coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #136      +/-   ##
===========================================
- Coverage    87.57%   87.50%   -0.08%     
===========================================
  Files            6        6              
  Lines          475      472       -3     
===========================================
- Hits           416      413       -3     
  Misses          59       59              
Impacted Files Coverage Δ
yaml2sbml/yaml2sbml.py 86.16% <ø> (-0.26%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 139300c...47a1f56. Read the comment docs.

Copy link
Member

@dilpath dilpath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jvanhoefer jvanhoefer merged commit 4ad4c8c into develop Jul 29, 2021
@jvanhoefer jvanhoefer deleted the fix_remove_unit_assignments branch July 29, 2021 21:58
Copy link
Member

@yannikschaelte yannikschaelte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too late but 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants