New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Poor performance past 0.2.1 #40
Comments
I did some spark profiling for 0.2.1 and 0.4.2 and something weird is definitely going on. Here is the 0.2.1 profile and here is the 0.4.2 profile Whatever the method |
Seems to be an issue with mod compatibility and hook injection logic. Currently the hook can potentially be injected at multiple points if other coremods insert Lines 45 to 86 in 8ee0a09
|
Fixes the incorrect hook injection target. Before this change, the hook was injected at every method instruction causing noticeable performance degradation. Fixes yamporg#40
Fixes the incorrect hook injection target. Before this change, the hook was injected at every method instruction causing noticeable performance degradation. Fixes #40
@TheComputerizer I've published v0.5.0 release with the fix, let me know if the issue is still relevant for you. |
Hey @tie: I have had this issue in the past as well. In my testing with |
I really should have reported this a while back when I noticed that, but I have been using
darkness-0.2.1-all
for a while instead of the newer versions due to every version past 0.2.1 cutting my FPS in half.I decided to do a direct FPS comparison between
darkness-0.2.1-all
,darkness-forge-1.12.x-0.4.2
, and Hardcore Darkness and here are the results of that.Unfortunately my FPS on latest version of this is still very bad.
Here is my modpack if you would like the list of mods. I am using the latest forge version of
14.23.5.2860
The text was updated successfully, but these errors were encountered: