Revert "Return error when exception was raised after main thread fini…

…shes (bytecodealliance#2169)" This reverts commit 71d43f3. for some reasons, the original commit assumes a trap should win over exit even if the former is 1 second later. i don't see any reason it should.
yamt · Aug 31, 2023 · c38eadf · c38eadf
1 parent 455061a
commit c38eadf
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 13 deletions.
diff --git a/core/iwasm/libraries/lib-wasi-threads/test/trap_after_main_thread_finishes.json b/core/iwasm/libraries/lib-wasi-threads/test/trap_after_main_thread_finishes.json
diff --git a/product-mini/platforms/posix/main.c b/product-mini/platforms/posix/main.c
@@ -921,12 +921,8 @@ main(int argc, char *argv[])
 
 #if WASM_ENABLE_LIBC_WASI != 0
     if (ret == 0) {
-        /* wait for threads to finish and propagate wasi exit code. */
+        /* propagate wasi exit code. */
         ret = wasm_runtime_get_wasi_exit_code(wasm_module_inst);
-        if (wasm_runtime_get_exception(wasm_module_inst)) {
-            /* got an exception in spawned thread */
-            ret = 1;
-        }
     }
 #endif
 

diff --git a/product-mini/platforms/windows/main.c b/product-mini/platforms/windows/main.c
@@ -554,12 +554,8 @@ main(int argc, char *argv[])
 
 #if WASM_ENABLE_LIBC_WASI != 0
     if (ret == 0) {
-        /* wait for threads to finish and propagate wasi exit code. */
+        /* propagate wasi exit code. */
         ret = wasm_runtime_get_wasi_exit_code(wasm_module_inst);
-        if (wasm_runtime_get_exception(wasm_module_inst)) {
-            /* got an exception in spawned thread */
-            ret = 1;
-        }
     }
 #endif