electron-prebuilt renamed

[keverw]

http://electron.atom.io/blog/2016/08/16/npm-install-electron

I went ahead and updated my project and removed prebuilt.

My code is:

require('electron-reload')(__dirname, {
        electron: require('electron')
    });

but I get "Electron could not be found. No hard resets for you!" when I start my app...

[yan-foto]

So you are only gonna have soft resets. I don't get the question?

[keverw]

I changed electron-prebuilt to electron since they renamed the package. Before it gave hard resets. For some reason, the package renaming stopped those from working when using the reload module.

[yan-foto]

electron-prebuilt still exists. I haven't yet played with the new one. I suppose you must have electron as local dependency so require actually finds it within your installed modules.

[keverw]

Yeah I had it installed locally. But I'm trying to do the two package.json build now - I discovered that earlier before I started on that. But I think in the future I want to move to TypeScript so i'd have to recompile and restart anyways from my understanding. So soft restarts would probably be good enough for my needs.

[yan-foto]

I will check this later today and update the documentation. Thanks for the heads up and sorry for the initial misunderstanding!

[ghost]

Do you have an update on this?

[yan-foto]

@JBodkin not yet. pull requests are welcome!

[ghost]

Looks to be related to the way require works, when using the new package name

Previously the index.js file would be loaded returning the path to the executable, Instead the electron.asar is loaded.

I was able to work around this by providing a path to the index.js inside the module home instead.

require('electron-reload')(__dirname, {
  electron: require('${__dirname}/../../node_modules/electron')
})

[yan-foto]

I somehow suspected that require(electrol) doesn't return a file path, as electron-reload only verifies if the path to electron executable exists.

I'll take a look at it. I would try to find another way, as require (with or without your proposed solution) doesn't seem to be the right way to solve this problem in the long run.

Thanks for taking a look at it. 👍 .

[yan-foto]

Ok guys, I am going to close this issue. I took a look at the whole situation and realized that obviously you cannot require electron the way you do electron-prebuilt. I enhanced the README to address this issue. In short: use explicit path of electron binary instead of require!

[yan-foto]

@Peter-Gess can depend on many things. You better should consult stackoverflow. Issues are preferably only for bugs.

[doncolio007]

Thanks @JBodkin. Fixed

[hari03]

Just a small note.

For @JBodkin comment suggestion generally fixes this issue but only if electron has been installed locally and is available inside your current development folder. Global install in your system doesn't fix the issue for me. I re-tried after a local install and it worked!

[rachidsakara]

make sure that the electron-reload module is installed locally in your project, if not the case Visit your console and type:
npm install electron-reload --save-dev
Now in order to implement this module in your project; the main file (index.js or main.js), you have tree options.
Option 1:
require('electron-reload')(__dirname)
Option 2:
require('electron-reload')(__dirname, { electron: require('${__dirname}/../../node_modules/electron') })
Option 3:
require('electron-reload')(__dirname, { electron: require('${__dirname}/node_modules/electron') })

[Eshva]

@rachidsakara Thank you for comment. It helped me. But the only thing you need to fix are quotes. You should use ` not ' for interpolation.

For instance the proper version of Option 3 is:
require('electron-reload')(__dirname, { electron: require(`${__dirname}/node_modules/electron`) })

[rachidsakara]

Hi! Mike Eshva for the comment. well I think if copy it the command from that answer it will works perfect on your coding Editor for instance Sublime Text.

…

On Wed, Jul 4, 2018 at 11:04 PM, Mike Eshva ***@***.***> wrote: @rachidsakara <https://github.com/rachidsakara> Thank you for comment. It helped me. But the only thing you need to fix are quotes. You should use ` not ' for interpolation. For instance the proper version of Option 3 is: require('electron-reload')(__dirname, { electron: require(`${__dirname}/node_modules/electron`) }) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ab-V3G6Aqhysb7qXVbaSJSAji2OzJ0ogks5uDTwAgaJpZM4KeSOH> .

[rachidsakara]

Hi! Mike Eshva thanks for the comment. well I think if you copy any command from that answer it will works perfect on your coding Editor for instance Sublime Text.

…

On Wed, Jul 4, 2018 at 11:04 PM, Mike Eshva ***@***.***> wrote: @rachidsakara <https://github.com/rachidsakara> Thank you for comment. It helped me. But the only thing you need to fix are quotes. You should use ` not ' for interpolation. For instance the proper version of Option 3 is: require('electron-reload')(__dirname, { electron: require(`${__dirname}/node_modules/electron`) }) — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#16 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/Ab-V3G6Aqhysb7qXVbaSJSAji2OzJ0ogks5uDTwAgaJpZM4KeSOH> .

[Eshva]

It will not. I've checked. For string interpolation you have to use backtick and you use single quote.

[anderm8]

Just FYI, backtick works, single quote did not for me.