Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Example: stream stt #65

Merged
merged 4 commits into from
Feb 28, 2022
Merged

Example: stream stt #65

merged 4 commits into from
Feb 28, 2022

Conversation

nikolaymatrosov
Copy link
Contributor

Только для корректной работы этого примера нужно апнуть версию nice-grpc до 1.0.6.
Но возможно это обновление зависимостей и так будет необходимо после того как в мастере @grpc/grpc-js появятся ожидаемые фиксы.

@DavyJohnes DavyJohnes self-requested a review February 14, 2022 08:29
DavyJohnes
DavyJohnes previously approved these changes Feb 14, 2022
View reviewed changes
@DavyJohnes
Copy link
Contributor

@nikolaymatrosov не очень понял, а почему этот пример требует обновления nice-grpc? Если без него работать не будет, полагаю мержить этот ПР не стоит.

@nikolaymatrosov
Copy link
Contributor Author

В grpc-js менялась сигнатура функции attachHttp2Stream grpc/grpc-node@d60c4ea
А это кажется выехало с 1.4.0

В nice-grpc это изменение было поддержано тут https://github.com/deeplay-io/nice-grpc/blob/master/packages/nice-grpc/src/utils/patchClientWritableStream.ts только в 1.0.6.

Да, можно подождать.

@DavyJohnes
Copy link
Contributor

Обновляю nice-grpc тут https://github.com/yandex-cloud/nodejs-sdk/pull/67/files

@DavyJohnes
Copy link
Contributor

@nikolaymatrosov а поребейзишь по свежей beta?

@DavyJohnes
Copy link
Contributor

@nikolaymatrosov пример локально работает? Можно мержить?

DavyJohnes
DavyJohnes reviewed Feb 28, 2022
View reviewed changes
examples/package.json Outdated
@@ -10,6 +10,10 @@
"author": "",
"license": "ISC",
"dependencies": {
"@yandex-cloud/nodejs-sdk": "^2.0.0-alpha.7"
"@yandex-cloud/nodejs-sdk": "^2.0.0-beta.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Тут наверное beta.2 надо?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@nikolaymatrosov
Copy link
Contributor Author

@nikolaymatrosov пример локально работает? Можно мержить?

Да.

@DavyJohnes DavyJohnes merged commit db7c199 into yandex-cloud:beta Feb 28, 2022
@yandex-cloud-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

@yandex-cloud-bot
Copy link
Collaborator

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavyJohnes DavyJohnes DavyJohnes left review comments

Assignees
No one assigned
Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nikolaymatrosov @DavyJohnes @yandex-cloud-bot