Improve yc-libvhost-server tests #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 5, 2024 08:59
Tests we currently have use pytest framework, so fail fast on setup stage if it's absent. Signed-off-by: Valentin Sinitsyn <valesini@yandex-team.ru>
Tests already accept setting test server path via TEST_SERVER_BINARY environment variable. However it was only effective if the test server wasn't found at its usual location in the build directory. Reverse the logic: check the environment first and only use a hard-coded path as a fallback. This way, a custom libvhost server which doesn't come bundled can be used in tests. This feels more intuitive as the environment variable is now an override, not the default. Signed-off-by: Valentin Sinitsyn <valesini@yandex-team.ru>
d-tatianin
reviewed
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit pytest dependency so it is checked on setup stage, and straightforward error message is printed if it's absent. Then, give
TEST_SERVER_BINARYenvironment variable (also set by Meson) a precedence over the hardcoded path, so custom buildroots don't break tests.