Разломался фиксированный попап при переходе на ES6 #515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitkarpov
force-pushed
the
fix-es6-at-string
branch
from
a872276
to
01a0233
Compare
|
+ докинул тестов на фиксированный попап, их просто не было |
|
👍 |
vitkarpov
added a commit
that referenced
this pull request
Dec 1, 2015
Разломался фиксированный попап при переходе на ES6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В ES6 появился метод
atу строки.У нас есть такой код:
how может быть строкой (
fixed) — соответственно, мы берем в качестве значения position.at ссылку на функцию из прототипаStringи все ломается.Сделал
howвсегда объектом. В случае если это строкаfixed, нужно просто сделать его равным{how: 'fixed'}— с таким объектом работает дальнейшая логика.