Fixed minor issue found by Coverity [#CLICKHOUSE-3285].

ClickHouse · Sep 8, 2017 · ed1c082 · ed1c082
1 parent 8738adf
commit ed1c082
Showing 1 changed file with 12 additions and 2 deletions.
diff --git a/dbms/src/Storages/System/StorageSystemGraphite.cpp b/dbms/src/Storages/System/StorageSystemGraphite.cpp
@@ -13,6 +13,11 @@
 namespace DB
 {
 
+namespace ErrorCodes
+{
+    extern const int NO_ELEMENTS_IN_CONFIG;
+}
+
 namespace
 {
 
@@ -42,7 +47,11 @@ static Pattern readOnePattern(
 
     config.keys(path, keys);
 
-    for (const auto & key : keys) {
+    if (keys.empty())
+        throw Exception("Empty pattern in Graphite rollup configuration", ErrorCodes::NO_ELEMENTS_IN_CONFIG);
+
+    for (const auto & key : keys)
+    {
         const String key_path = path + "." + key;
 
         if (startsWith(key, "regexp"))
@@ -74,7 +83,8 @@ static std::vector<Pattern> readPatterns(
 
     config.keys(section, keys);
 
-    for (const auto & key : keys) {
+    for (const auto & key : keys)
+    {
         if (startsWith(key, "pattern"))
         {
             Pattern pattern(readOnePattern(config, section + "." + key));