alter table MODIFY COLUMN is failing when there are NULL values involved #1322

silviucpp · 2017-10-05T09:35:26Z

Clickhouse version: 1.1.54293

CREATE TABLE table2(`boolean_false` Nullable(String), `ck.partition` Date, `ck.timestamp` DateTime) ENGINE = ReplicatedMergeTree('/var/lib/clickhouse/tables/{shard}/table2','{replica}',`ck.partition`,`ck.timestamp`,8192);
INSERT INTO table2(`ck.timestamp`,`ck.partition`, `boolean_false`) VALUES (1507193820,17444,NULL);
ALTER TABLE table2 MODIFY COLUMN `boolean_false` Nullable(UInt8)

Last command fails with:

Code: 341, e.displayText() = DB::Exception: Alter is not finished because timeout when waiting for some replicas: 01 (replication_alter_columns_timeout = 60). Alter will be done asynchronously., e.what() = DB::Exceptio

And logs is spammed with the following:

0. clickhouse-server(StackTrace::StackTrace()+0x16) [0x2fed876]
1. clickhouse-server(DB::Exception::Exception(std::string const&, int)+0x1f) [0x12ee80f]
2. clickhouse-server(DB::throwReadAfterEOF()+0x3c) [0x12ee86c]
3. clickhouse-server(DB::ConvertImpl<DB::DataTypeString, DB::DataTypeNumber<unsigned char>, DB::NameToUInt8>::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x2c4) [0x19baaa4]
4. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeInternal(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x445) [0x19ca195]
5. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x20) [0x19ca3d0]
6. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
7. clickhouse-server(DB::FunctionCast::prepare(std::shared_ptr<DB::IDataType> const&, DB::IDataType const*, unsigned long)::{lambda(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)#1}::operator()(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long) const+0x1f2) [0x1984362]
8. clickhouse-server(DB::FunctionCast::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x8c) [0x198410c]
9. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
10. clickhouse-server(DB::ExpressionAction::execute(DB::Block&) const+0x292) [0x2fd0072]
11. clickhouse-server(DB::ExpressionActions::execute(DB::Block&) const+0x32) [0x2fd21f2]
12. clickhouse-server(DB::ExpressionBlockInputStream::readImpl()+0x33) [0x328e7b3]
13. clickhouse-server(DB::IProfilingBlockInputStream::read()+0x1e6) [0x298a4f6]
14. clickhouse-server(DB::MergeTreeData::alterDataPart(std::shared_ptr<DB::MergeTreeDataPart const> const&, DB::NamesAndTypesList const&, std::shared_ptr<DB::IAST> const&, bool)+0x127c) [0x314b9fc]
15. clickhouse-server(DB::ReplicatedMergeTreeAlterThread::run()+0xd16) [0x31e76c6]
16. clickhouse-server() [0x3d2f20f]
17. /lib/x86_64-linux-gnu/libpthread.so.0(+0x8184) [0x7f12f9673184]
18. /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f12f8c8dffd]

2017.10.05 09:15:12.422550 [ 68 ] <Warning> system.table2 (Data): Aborting ALTER of part 20171005_20171005_0_0_0
2017.10.05 09:15:12.457086 [ 68 ] <Error> void DB::ReplicatedMergeTreeAlterThread::run(): Code: 32, e.displayText() = DB::Exception: Attempt to read after eof: Cannot parse UInt8 from String, because value is too short, e.what() = DB::Exception, Stack trace:

0. clickhouse-server(StackTrace::StackTrace()+0x16) [0x2fed876]
1. clickhouse-server(DB::Exception::Exception(std::string const&, int)+0x1f) [0x12ee80f]
2. clickhouse-server(DB::throwReadAfterEOF()+0x3c) [0x12ee86c]
3. clickhouse-server(DB::ConvertImpl<DB::DataTypeString, DB::DataTypeNumber<unsigned char>, DB::NameToUInt8>::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x2c4) [0x19baaa4]
4. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeInternal(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x445) [0x19ca195]
5. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x20) [0x19ca3d0]
6. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
7. clickhouse-server(DB::FunctionCast::prepare(std::shared_ptr<DB::IDataType> const&, DB::IDataType const*, unsigned long)::{lambda(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)#1}::operator()(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long) const+0x1f2) [0x1984362]
8. clickhouse-server(DB::FunctionCast::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x8c) [0x198410c]
9. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
10. clickhouse-server(DB::ExpressionAction::execute(DB::Block&) const+0x292) [0x2fd0072]
11. clickhouse-server(DB::ExpressionActions::execute(DB::Block&) const+0x32) [0x2fd21f2]
12. clickhouse-server(DB::ExpressionBlockInputStream::readImpl()+0x33) [0x328e7b3]
13. clickhouse-server(DB::IProfilingBlockInputStream::read()+0x1e6) [0x298a4f6]
14. clickhouse-server(DB::MergeTreeData::alterDataPart(std::shared_ptr<DB::MergeTreeDataPart const> const&, DB::NamesAndTypesList const&, std::shared_ptr<DB::IAST> const&, bool)+0x127c) [0x314b9fc]
15. clickhouse-server(DB::ReplicatedMergeTreeAlterThread::run()+0xd16) [0x31e76c6]
16. clickhouse-server() [0x3d2f20f]
17. /lib/x86_64-linux-gnu/libpthread.so.0(+0x8184) [0x7f12f9673184]
18. /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f12f8c8dffd]

2017.10.05 09:15:22.458944 [ 68 ] <Warning> system.table2 (Data): Aborting ALTER of part 20171005_20171005_0_0_0
2017.10.05 09:15:22.493252 [ 68 ] <Error> void DB::ReplicatedMergeTreeAlterThread::run(): Code: 32, e.displayText() = DB::Exception: Attempt to read after eof: Cannot parse UInt8 from String, because value is too short, e.what() = DB::Exception, Stack trace:

0. clickhouse-server(StackTrace::StackTrace()+0x16) [0x2fed876]
1. clickhouse-server(DB::Exception::Exception(std::string const&, int)+0x1f) [0x12ee80f]
2. clickhouse-server(DB::throwReadAfterEOF()+0x3c) [0x12ee86c]
3. clickhouse-server(DB::ConvertImpl<DB::DataTypeString, DB::DataTypeNumber<unsigned char>, DB::NameToUInt8>::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x2c4) [0x19baaa4]
4. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeInternal(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x445) [0x19ca195]
5. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x20) [0x19ca3d0]
6. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
7. clickhouse-server(DB::FunctionCast::prepare(std::shared_ptr<DB::IDataType> const&, DB::IDataType const*, unsigned long)::{lambda(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)#1}::operator()(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long) const+0x1f2) [0x1984362]
8. clickhouse-server(DB::FunctionCast::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x8c) [0x198410c]
9. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
10. clickhouse-server(DB::ExpressionAction::execute(DB::Block&) const+0x292) [0x2fd0072]
11. clickhouse-server(DB::ExpressionActions::execute(DB::Block&) const+0x32) [0x2fd21f2]
12. clickhouse-server(DB::ExpressionBlockInputStream::readImpl()+0x33) [0x328e7b3]
13. clickhouse-server(DB::IProfilingBlockInputStream::read()+0x1e6) [0x298a4f6]
14. clickhouse-server(DB::MergeTreeData::alterDataPart(std::shared_ptr<DB::MergeTreeDataPart const> const&, DB::NamesAndTypesList const&, std::shared_ptr<DB::IAST> const&, bool)+0x127c) [0x314b9fc]
15. clickhouse-server(DB::ReplicatedMergeTreeAlterThread::run()+0xd16) [0x31e76c6]
16. clickhouse-server() [0x3d2f20f]
17. /lib/x86_64-linux-gnu/libpthread.so.0(+0x8184) [0x7f12f9673184]
18. /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f12f8c8dffd]

2017.10.05 09:15:32.495881 [ 68 ] <Warning> system.table2 (Data): Aborting ALTER of part 20171005_20171005_0_0_0
2017.10.05 09:15:32.529583 [ 68 ] <Error> void DB::ReplicatedMergeTreeAlterThread::run(): Code: 32, e.displayText() = DB::Exception: Attempt to read after eof: Cannot parse UInt8 from String, because value is too short, e.what() = DB::Exception, Stack trace:

0. clickhouse-server(StackTrace::StackTrace()+0x16) [0x2fed876]
1. clickhouse-server(DB::Exception::Exception(std::string const&, int)+0x1f) [0x12ee80f]
2. clickhouse-server(DB::throwReadAfterEOF()+0x3c) [0x12ee86c]
3. clickhouse-server(DB::ConvertImpl<DB::DataTypeString, DB::DataTypeNumber<unsigned char>, DB::NameToUInt8>::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x2c4) [0x19baaa4]
4. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeInternal(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x445) [0x19ca195]
5. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x20) [0x19ca3d0]
6. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
7. clickhouse-server(DB::FunctionCast::prepare(std::shared_ptr<DB::IDataType> const&, DB::IDataType const*, unsigned long)::{lambda(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)#1}::operator()(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long) const+0x1f2) [0x1984362]
8. clickhouse-server(DB::FunctionCast::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x8c) [0x198410c]
9. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
10. clickhouse-server(DB::ExpressionAction::execute(DB::Block&) const+0x292) [0x2fd0072]
11. clickhouse-server(DB::ExpressionActions::execute(DB::Block&) const+0x32) [0x2fd21f2]
12. clickhouse-server(DB::ExpressionBlockInputStream::readImpl()+0x33) [0x328e7b3]
13. clickhouse-server(DB::IProfilingBlockInputStream::read()+0x1e6) [0x298a4f6]
14. clickhouse-server(DB::MergeTreeData::alterDataPart(std::shared_ptr<DB::MergeTreeDataPart const> const&, DB::NamesAndTypesList const&, std::shared_ptr<DB::IAST> const&, bool)+0x127c) [0x314b9fc]
15. clickhouse-server(DB::ReplicatedMergeTreeAlterThread::run()+0xd16) [0x31e76c6]
16. clickhouse-server() [0x3d2f20f]
17. /lib/x86_64-linux-gnu/libpthread.so.0(+0x8184) [0x7f12f9673184]
18. /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f12f8c8dffd]

2017.10.05 09:15:42.531570 [ 68 ] <Warning> system.table2 (Data): Aborting ALTER of part 20171005_20171005_0_0_0
2017.10.05 09:15:42.566048 [ 68 ] <Error> void DB::ReplicatedMergeTreeAlterThread::run(): Code: 32, e.displayText() = DB::Exception: Attempt to read after eof: Cannot parse UInt8 from String, because value is too short, e.what() = DB::Exception, Stack trace:

0. clickhouse-server(StackTrace::StackTrace()+0x16) [0x2fed876]
1. clickhouse-server(DB::Exception::Exception(std::string const&, int)+0x1f) [0x12ee80f]
2. clickhouse-server(DB::throwReadAfterEOF()+0x3c) [0x12ee86c]
3. clickhouse-server(DB::ConvertImpl<DB::DataTypeString, DB::DataTypeNumber<unsigned char>, DB::NameToUInt8>::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x2c4) [0x19baaa4]
4. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeInternal(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x445) [0x19ca195]
5. clickhouse-server(DB::FunctionConvert<DB::DataTypeNumber<unsigned char>, DB::NameToUInt8, DB::ToIntMonotonicity<unsigned char> >::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x20) [0x19ca3d0]
6. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
7. clickhouse-server(DB::FunctionCast::prepare(std::shared_ptr<DB::IDataType> const&, DB::IDataType const*, unsigned long)::{lambda(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)#1}::operator()(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long) const+0x1f2) [0x1984362]
8. clickhouse-server(DB::FunctionCast::executeImpl(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x8c) [0x198410c]
9. clickhouse-server(DB::IFunction::execute(DB::Block&, std::vector<unsigned long, std::allocator<unsigned long> > const&, unsigned long)+0x125) [0x3205c55]
10. clickhouse-server(DB::ExpressionAction::execute(DB::Block&) const+0x292) [0x2fd0072]
11. clickhouse-server(DB::ExpressionActions::execute(DB::Block&) const+0x32) [0x2fd21f2]
12. clickhouse-server(DB::ExpressionBlockInputStream::readImpl()+0x33) [0x328e7b3]
13. clickhouse-server(DB::IProfilingBlockInputStream::read()+0x1e6) [0x298a4f6]
14. clickhouse-server(DB::MergeTreeData::alterDataPart(std::shared_ptr<DB::MergeTreeDataPart const> const&, DB::NamesAndTypesList const&, std::shared_ptr<DB::IAST> const&, bool)+0x127c) [0x314b9fc]
15. clickhouse-server(DB::ReplicatedMergeTreeAlterThread::run()+0xd16) [0x31e76c6]
16. clickhouse-server() [0x3d2f20f]
17. /lib/x86_64-linux-gnu/libpthread.so.0(+0x8184) [0x7f12f9673184]
18. /lib/x86_64-linux-gnu/libc.so.6(clone+0x6d) [0x7f12f8c8dffd]

The text was updated successfully, but these errors were encountered:

…be parsed: development #1322

silviucpp · 2018-01-02T20:53:58Z

@alexey-milovidov This bug is still present on master

silviucpp · 2018-07-11T18:11:29Z

@alexey-milovidov Also this one I'm not sure was not fixed in the meantime. I didn't checked on the master but seems nobody reviewed it to mark it as bug or close it.

alexey-milovidov · 2018-07-11T18:35:26Z

Yes, it isn't fixed.

alexey-milovidov · 2018-07-11T18:38:18Z

The most simple case:

SELECT CAST(arrayJoin(['1', NULL]), 'Nullable(UInt8)')

Received exception from server (version 1.1.54391):
Code: 32. DB::Exception: Received from localhost:9000, 127.0.0.1. DB::Exception: Attempt to read after eof: Cannot parse UInt8 from String, because value is too short.

…nts (incomplete) #1322

…teTime #1322

…nts (incomplete) #1322

…teTime #1322

silviucpp mentioned this issue Oct 11, 2017

DB::Exception: Attempt to read after eof when try compare nullable columns #1285

Closed

silviucpp changed the title ~~alter table is failing and leaves cluster in a strange state~~ alter table MODIFY COLUMN is failing when there are NULL values involved Nov 1, 2017

silviucpp mentioned this issue Dec 8, 2017

Nullable simplification #1598

Merged

alexey-milovidov added a commit that referenced this issue Dec 25, 2017

Proper conversions from String to Nullable types if the value cannot …

a168c77

…be parsed: development #1322

alexey-milovidov added a commit that referenced this issue Dec 25, 2017

Added functions toNumberOrNull from String argument #1322

d899d3f

alexey-milovidov self-assigned this Jul 11, 2018

alexey-milovidov added the bug Confirmed user-visible misbehaviour in official release label Jul 11, 2018

alexey-milovidov added a commit that referenced this issue Jul 11, 2018

Miscellaneous #1322

14d5aa0

alexey-milovidov added a commit that referenced this issue Jul 11, 2018

More accurate conversion to Nullable type in function CAST #1322

8a60c3d

alexey-milovidov added a commit that referenced this issue Jul 11, 2018

Implemented toOrZero, toOrNull functions for Date and DateTime argume…

7dc9e1e

…nts (incomplete) #1322

alexey-milovidov added a commit that referenced this issue Jul 14, 2018

Implemented more accurate CAST from String to Nullable of Date and Da…

3609bfe

…teTime #1322

alexey-milovidov added a commit that referenced this issue Jul 14, 2018

Added test #1322

4c28982

alexey-milovidov added a commit that referenced this issue Jul 14, 2018

Added a test from Silviu Caragea #1322

eabd8ad

alexey-milovidov mentioned this issue Jul 14, 2018

More accurate parsing when cast to nullable #2649

Merged

alexey-milovidov added a commit that referenced this issue Jul 16, 2018

More accurate conversion to Nullable type in function CAST #1322

8533011

alexey-milovidov added a commit that referenced this issue Jul 16, 2018

Implemented toOrZero, toOrNull functions for Date and DateTime argume…

297805f

…nts (incomplete) #1322

alexey-milovidov added a commit that referenced this issue Jul 16, 2018

Implemented more accurate CAST from String to Nullable of Date and Da…

eee0214

…teTime #1322

alexey-milovidov added a commit that referenced this issue Jul 16, 2018

Added test #1322

13e5b24

alexey-milovidov added a commit that referenced this issue Jul 16, 2018

Added a test from Silviu Caragea #1322

63d3d9c

alexey-milovidov closed this as completed Jul 16, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

alter table MODIFY COLUMN is failing when there are NULL values involved #1322

alter table MODIFY COLUMN is failing when there are NULL values involved #1322

silviucpp commented Oct 5, 2017

silviucpp commented Jan 2, 2018

silviucpp commented Jul 11, 2018

alexey-milovidov commented Jul 11, 2018

alexey-milovidov commented Jul 11, 2018

alter table MODIFY COLUMN is failing when there are NULL values involved #1322

alter table MODIFY COLUMN is failing when there are NULL values involved #1322

Comments

silviucpp commented Oct 5, 2017

silviucpp commented Jan 2, 2018

silviucpp commented Jul 11, 2018

alexey-milovidov commented Jul 11, 2018

alexey-milovidov commented Jul 11, 2018