MySQL engine can't identify keywords from mysql5.8

[wowtous]

clickhouse version: 1.1.54390
mysql version: 8.0.4-rc-log

1. conf

hostname: 127.0.0.1
port: 3306
username: test
password: test

2. create a mysql test table and insert some test data.

create table test.test (id int,rank int(11),name varchar(100));
insert into test.test (id,rank,name) values (1,1,'test1'),(2,2,'test2'),(3,3,'test3');

3. create MySQL engine table in the CH

create database test;
create table test.test (
 id Int32,
 rank Int32,
 name String
) ENGINE = MySQL('127.0.0.1:3306', 'test', 'test', 'test', 'test', 1) ;

when I query like this:

select * from test.test;
select rank from test.test

The error is:

Received exception from server (version 1.1.54390):
Code: 1000. DB::Exception: Received from 127.0.0.1:9000. DB::Exception: mysqlxx::BadQuery: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'rank) VALUES...

[alexey-milovidov]

Confirmed. We should quote all identifiers in a query for external database.

[wowtous]

good job