Query in form data #2490
Closed
Query in form data #2490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch is very crucial in case of many replicas.
|
Please add a test. Look at |
|
Also need to test when query is in URL parameter, but there are external tables in multipart/form-data. |
stavrolia
added a commit
to stavrolia/ClickHouse
that referenced
this pull request
Jun 25, 2018
|
There is a basic test, and what do you mean by external tables? |
|
In updated version of this branch it is able to send >16K (I tested on 20K). I can add it to test if necessary. |
robot-metrika-test
force-pushed
the
stable
branch
from
6a57f55
to
e03d523
Compare
|
Merged manually |
|
Looks perfectly correct. Thank you! |
alexey-milovidov
added a commit
that referenced
this pull request
Jul 2, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Jul 4, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Jul 4, 2018
alexey-milovidov
added a commit
that referenced
this pull request
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
New feature: now you can send query to HTTP api along with
multipart/form-dataas file with namequery. It is usable, if you have to send external tables, but your query is big enough to be sent via GET param (in uri).It can be tested with:
curl localhost:8123/?query="select" -X POST -F "query= 1;"