Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log number of skipped rows during a bulk insert #2669

Merged
merged 1 commit into from
Jul 18, 2018

Conversation

leonardoce
Copy link
Contributor

When in a bulk insert the rows are parsed server-side and there are
skipped rows, log the number of these rows at the TRACE level.

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@alexey-milovidov
Copy link
Member

alexey-milovidov commented Jul 17, 2018

Probably it will be better to log inside readSuffix method?

@leonardoce
Copy link
Contributor Author

Probably it will be better to log inside readSuffix method?

Sure. I'll fix the patch.

When in a bulk insert the rows are parsed server-side and there are
skipped rows, log the number of these rows at the TRACE level.
@leonardoce
Copy link
Contributor Author

Fixed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants