Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ISSUES-2700 fix windowFunnel NULL pointer #2735

Merged
merged 1 commit into from
Jul 27, 2018
Merged

ISSUES-2700 fix windowFunnel NULL pointer #2735

merged 1 commit into from
Jul 27, 2018

Conversation

zhang2014
Copy link
Contributor

#2700

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

@zhang2014 @sundy-li
ISSUES-2700 fix windowFunnel NULL pointer
4bc9160 
Co-authored-by: zhang2014 <coswde@gmail.com>
Co-authored-by: sundy-li <543950155@qq.com>
@alexey-milovidov alexey-milovidov merged commit 58ebe8d into ClickHouse:master Jul 27, 2018
@lamberken
Copy link
Contributor

👍

@alexey-milovidov
Copy link
Member

Could you please also add a test?

It's rather simple. You can use remote('127.0.0.{1,2}', ... to perform distributed query (and force serialization and deserialization of aggregate states). It would be perfect if the test will reproduce the bug in older version.

The test should have word shard in its name. (It means, that the test assumes that the server is listening wildcard address.)

@zhang2014 zhang2014 mentioned this pull request Jul 30, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zhang2014 @lamberken @alexey-milovidov