Fix crash in median over Nullable(Decimal128) #6378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4ertus2
changed the title
|
There's no alignment in AllocatorWithStackMemory. It leads to crash in attepmt to push_back __int128 into PODArrayWithStackMemory |
|
Also we can replace |
4ertus2
changed the title
alexey-milovidov
requested changes
Aug 8, 2019
dbms/src/Common/PODArray.h
Outdated
| @@ -636,6 +636,6 @@ using PaddedPODArray = PODArray<T, initial_bytes, TAllocator, 15, 16>; | |||
| template <typename T, size_t inline_bytes, | |||
| size_t rounded_bytes = integerRoundUp(inline_bytes, sizeof(T))> | |||
| using PODArrayWithStackMemory = PODArray<T, rounded_bytes, | |||
| AllocatorWithStackMemory<Allocator<false>, rounded_bytes>>; | |||
| AllocatorWithStackMemory<Allocator<false>, rounded_bytes, ((sizeof(T) < 16) ? sizeof(T) : 16)>>; | |||
There was a problem hiding this comment.
There is also alignof keyword.
CurtizJ
pushed a commit
that referenced
this pull request
Aug 9, 2019
Fix crash in median over Nullable(Decimal128) (cherry picked from commit b579692)
CurtizJ
pushed a commit
that referenced
this pull request
Aug 9, 2019
Fix crash in median over Nullable(Decimal128) (cherry picked from commit b579692)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Category (leave one):
Short description (up to few sentences):
Crash in median over Nullable(Decimal128)