Canvas.generateDataURLHeatmap: return empty string if there is no points #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ch-ms
force-pushed
the
chams-ff59-macos10.13.3-fix
branch
from
21f3d32
to
7624ed0
Compare
alt-j
approved these changes
Mar 26, 2018
ch-ms
force-pushed
the
chams-ff59-macos10.13.3-fix
branch
from
ea6bf1f
to
b45fa45
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В 59 версии Фаерфокс под Мак Ос 10.13.3 некорректно рисуются тайлы, а именно на тайлах которые должны быть пустыми остается фантомное изображение (https://s3.amazonaws.com/chms/yandex-heatmap-ff59-bug/bug.png). Этот пул исправляет это следующим образом: если нет точек тогда generateDataURLHeatmap возвращает пустое значение. Это полностью убирает ошибку (https://s3.amazonaws.com/chms/yandex-heatmap-ff59-bug/wo-bug.png) и позволяет избежать дополнительных вычислений.