Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more request examples #192

Closed
wants to merge 7 commits into from
Closed

Add more request examples #192

wants to merge 7 commits into from

Conversation

elsid
Copy link
Collaborator

@elsid elsid commented Oct 15, 2019

No description provided.


// All IO is asynchronous, therefore we have a choice here, what should be our CompletionToken.
// We use callback function that will be called after operation is finished.
const auto callback = [result] (ozo::error_code ec, auto connection) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The callback may be a functional object with the result stored as std::unique_ptr. Ozo now works fine with non-copyable callbacks.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@codecov
Copy link

codecov bot commented Nov 11, 2019

Codecov Report

Merging #192 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #192   +/-   ##
======================================
  Coverage    95.1%   95.1%           
======================================
  Files          79      79           
  Lines        1737    1737           
  Branches      472     472           
======================================
  Hits         1652    1652           
  Misses         28      28           
  Partials       57      57

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d97796...7909881. Read the comment docs.

@elsid
Copy link
Collaborator Author

elsid commented Nov 17, 2019

Close until it's done.

@elsid elsid closed this Nov 17, 2019
@elsid elsid deleted the request_examples branch November 17, 2019 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants