Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass common dependencies to core plugins #57

Closed
skipor opened this issue Jul 24, 2017 · 0 comments
Closed

Pass common dependencies to core plugins #57

skipor opened this issue Jul 24, 2017 · 0 comments

Comments

@skipor
Copy link
Contributor

skipor commented Jul 24, 2017

Pass core.Deps struct to Aggregator, Provider and Gun as an arg to their Run (Bind) methods.

What put to core.Deps:
1). zap.Logger
2) some metrics registry. I think something custom based on go-metrics
3) registry, to register what will be logged as every second shooting status
4) afero.Fs? Not shure really.
Document, that some fields may be added in future versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant