Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OptimalMetricNdim - better documentation #31

Closed
arogozhnikov opened this issue Aug 17, 2015 · 1 comment
Closed

OptimalMetricNdim - better documentation #31

arogozhnikov opened this issue Aug 17, 2015 · 1 comment
Assignees
@tlikhomanenko
Labels
enhancement
Milestone
0.6.4

Comments

@arogozhnikov
Copy link
Contributor

  1. OptimalMetricNdim doesn't follow metric conventions. This should be said explicitly + no derivation from metric mixin + rename call to something like compute_optimum
  2. Good explanation (probably with example) is needed as well.
@arogozhnikov arogozhnikov added this to the 0.6.4 milestone Aug 17, 2015
tlikhomanenko pushed a commit that referenced this issue Oct 23, 2015
fix OptimalNdimMetric #31
4ddfad3
@tlikhomanenko
Copy link
Contributor

Fixed in commit 4ddfad3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tlikhomanenko tlikhomanenko

Labels
enhancement
Projects
None yet
Milestone
0.6.4
Development

No branches or pull requests
2 participants
@arogozhnikov @tlikhomanenko