Skip to content

Commit

Permalink
Merge pull request #577 from yandex/master
Browse files Browse the repository at this point in the history
hotfix unicode job name
  • Loading branch information
fomars committed Apr 26, 2018
2 parents a9bd1b4 + 24e7331 commit 895939a
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 9 deletions.
6 changes: 3 additions & 3 deletions docs/tutorial.rst
Original file line number Diff line number Diff line change
Expand Up @@ -381,9 +381,9 @@ Now, our basic config looks like that:
phantom:
address: 203.0.113.1:443
load_profile:
load_type: rps
schedule: line(1, 10, 10m)
load_profile:
load_type: rps
schedule: line(1, 10, 10m)
ssl: true
.. note::
Expand Down
4 changes: 2 additions & 2 deletions yandextank/core/tankcore.py
Original file line number Diff line number Diff line change
Expand Up @@ -302,7 +302,7 @@ def plugins_end_test(self, retcode):
retcode = plugin.end_test(retcode)
logger.debug("RC after: %s", retcode)
except Exception: # FIXME too broad exception clause
logger.error("Failed finishing plugin %s: %s", plugin, exc_info=True)
logger.error("Failed finishing plugin %s", plugin, exc_info=True)
if not retcode:
retcode = 1
return retcode
Expand All @@ -320,7 +320,7 @@ def plugins_post_process(self, retcode):
retcode = plugin.post_process(retcode)
logger.debug("RC after: %s", retcode)
except Exception: # FIXME too broad exception clause
logger.error("Failed post-processing plugin %s: %s", plugin, exc_info=True)
logger.error("Failed post-processing plugin %s", plugin, exc_info=True)
if not retcode:
retcode = 1
self._collect_artifacts()
Expand Down
10 changes: 6 additions & 4 deletions yandextank/plugins/DataUploader/plugin.py
Original file line number Diff line number Diff line change
Expand Up @@ -315,8 +315,10 @@ def post_process(self, rc):
self.events_processing.close()
self.events.join()
logger.info("Waiting for sender threads to join.")
self.monitoring.join()
self.upload.join()
if self.monitoring.is_alive():
self.monitoring.join()
if self.upload.is_alive():
self.upload.join()
self.finished = True
try:
self.lp_job.close(rc)
Expand Down Expand Up @@ -584,8 +586,8 @@ def __get_lp_job(self):
token=self.get_option('upload_token'),
person=self.__get_operator(),
task=self.task,
name=self.get_option('job_name', 'none').decode('utf8'),
description=self.get_option('job_dsc').decode('utf8'),
name=self.get_option('job_name', 'none'),
description=self.get_option('job_dsc'),
tank=self.core.job.tank,
notify_list=self.get_option("notify"),
load_scheme=loadscheme,
Expand Down

0 comments on commit 895939a

Please sign in to comment.