Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental traceresponse propagator #44

Open
plantfansam opened this issue Oct 26, 2022 · 2 comments
Open

Add experimental traceresponse propagator #44

plantfansam opened this issue Oct 26, 2022 · 2 comments

Comments

@plantfansam
Copy link
Contributor

The editor's draft of tracecontext includes a traceresponse header, which can be used for load balancer deferred sampling:

When a service initially makes the decision to not sample a particular request, and also makes an outbound call to another downstream service, there may be some event during the processing of that request which causes the downstream service to decide to sample after all. In this case, the downstream service may return its updated sampling decision to the caller via the traceresponse header. Based on this, the caller may change its sampling decision and in turn also return its updated sampling decision to its caller, and so on. In this way, as much of a trace as possible may be recovered for troubleshooting purposes even if the original sampling decision was negative.

This requires a propagator that can extract context from a traceresponse header and attach a traceresponse header to ngx.req. @yangxikun would you be interested in keeping this code in this repository?

@yangxikun
Copy link
Owner

Sure.

@plantfansam
Copy link
Contributor Author

Per #35, we don't want this yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants