[DRAFT] Update name and interface for textmapgetter/textmapsetter #45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working on #44 (see draft), I learned that
ngx.req.set_header
does not set response headers. There is also a special method for getting response headers (ngx.resp.get_headers()
). To avoid confusion, I renamedtext_map_getter
andtext_map_setter
torequest_header_getter
andrequest_header_setter
.To maintain symmetry between
request_header_*
andresponse_header_*
, I also updated the propagators to assume thatngx
was passed to them (instead ofngx.req
). If we do not change this assumption, then the trace context propagator and baggage propagator would acceptngx.req
as a carrier, while thetraceresponse
propagator would acceptngx
.This would be a breaking change. It's OK if you'd rather not change the existing propagators @yangxikun, just let me know.