Allow user to specify start time #94
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plantfansam
suggested changes
Mar 26, 2024
| @@ -23,13 +23,13 @@ local mt = { | |||
| -- config.attributes: span attributes | |||
| -- @return span | |||
| ------------------------------------------------------------------ | |||
| function _M.new(tracer, parent_ctx, ctx, name, config) | |||
| function _M.new(tracer, parent_ctx, ctx, name, config, start_time) | |||
There was a problem hiding this comment.
Can we add arg to docstring above?
There was a problem hiding this comment.
oh of course, great catch
rdooley
force-pushed
the
span-start-time
branch
from
7484100
to
538fafd
Compare
|
how did the test pass because I forgot to alter the |
|
This i think needs some work, I will do additional lua unit testing as well |
* only use for recording spans * yangxikun#86
rdooley
force-pushed
the
span-start-time
branch
from
538fafd
to
4ae2cd9
Compare
rdooley
commented
Mar 26, 2024
| @@ -36,6 +36,8 @@ describe("encode_spans", function() | |||
| local resource = encoded.resource_spans[1] | |||
| assert(#resource.instrumentation_library_spans == 1) | |||
| assert(#resource.instrumentation_library_spans[1].spans == 10) | |||
| assert(resource.instrumentation_library_spans[1].spans[1].start_time_unix_nano == "123456788") | |||
| assert(resource.instrumentation_library_spans[1].spans[1].end_time_unix_nano == "123456789") | |||
There was a problem hiding this comment.
Just a nice addition here to check that we are setting and exporting the times we expect on spans
plantfansam
approved these changes
Mar 26, 2024
Co-authored-by: Sam <370182+plantfansam@users.noreply.github.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracer.start#86