Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support eslint fix #15

Merged
merged 1 commit into from
Dec 15, 2018
Merged

feat: support eslint fix #15

merged 1 commit into from
Dec 15, 2018

Conversation

HOUCe
Copy link
Collaborator

@HOUCe HOUCe commented Dec 5, 2018

We should run eslint --fix when execute lint command

We should run `eslint --fix` when execute `lint` command
@@ -10,7 +10,7 @@
"scripts:ts": {
"rename": "node rename.js",
"clean": "rimraf ./dist",
"lint": "tslint -c tslint.json src/**.ts",
"lint": "tslint -c tslint.json src/**.ts eslint --fix",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个ts的不应该添加eslint吧?

@@ -23,7 +23,7 @@
"scripts": {
"rename": "node rename.js",
"clean": "rimraf ./dist",
"lint": "eslint -c .eslintrc.js src/**.js",
"lint": "eslint -c .eslintrc.js src/**.js --fix",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个参数是不是要放到 路径前面去?

@yanhaijing
Copy link
Owner

可以添加一个 lint:fix 给本地使用

npm run lint:fix 

@yanhaijing yanhaijing merged commit 25f6c89 into yanhaijing:master Dec 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants