make before_release trigger during release (and others) #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See [rt.cpan.org #84744].
Fixes [rt.cpan.org #84744].
See [rt.cpan.org #84359].
Fixes [rt.cpan.org #84359].
Make it more obvious that the user must reference a PreviousVersionProvider-consuming plugin in dist.ini. Partially addresses [rt.cpan.org #84359].
|
Thanks. I'll review and absorb as soon as I can. Probably tomorrow night. |
|
Thanks, Yanick. If there's anything else I can do to assist with the release of these changes to CPAN, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In v0.1.0 of
Dist::Zilla::Plugin::NextVersion::Semantic, thebefore_releasemethod never runs because the plugin doesn't consume theDist::Zilla::Role::BeforeReleaserole.This pull request includes a test for the problem and a fix, and resolves [rt.cpan.org #84744].
Update: It seems that I haven't quite mastered pull requests, and some other commits for unrelated things have made it in as well. This pull request now also addresses issues raised in [rt.cpan.org #84359].