Fix #163 #181
Fix #163 #181
Conversation
1 similar comment
|
Is this going to get merged anytime soon? |
|
My current workaround is to just add {
"scripts": {
"test": "htmlhint src/**/*.html"
}
}I've got {
"scripts": {
"test": "htmlhint -c .htmlhintrc src/**/*.html"
}
} |
|
I imagine another workaround could be this: npm remove htmlhint
npm install "https://github.com/phaux/HTMLHint.git#patch-1" |
|
Are you hinting that @phaux has a patch for this and he will merge it into master soon? |
|
@trisys3 I mean....this Pull Request is the patch, but, as you know, it's taking a while to get merged. |
|
Oh, I don't know how GitHub patch URL's work, I'll have to look them up later. |
| @@ -300,12 +300,13 @@ function getConfig(configPath, base, formatter){ | |||
| if(fs.statSync(base).isDirectory() === false){ | |||
| base = path.dirname(base); | |||
| } | |||
| while(base){ | |||
| var tmpConfigFile = path.resolve(base+path.sep, '.htmlhintrc'); | |||
| while(true){ | |||
There was a problem hiding this comment.
Yes, maybe that works
But can you rewrite this in a way that does not use an always true statement in the while clause?
This conflicts with the eslint rule no-constant-condition and we want that later in our project
Codecov Report
@@ Coverage Diff @@
## master #181 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 1 1
Lines 1 1
=====================================
Hits 1 1Continue to review full report at Codecov.
|
thedaviddias
added
#status: awaiting reply
enhancement
**Fixes**: #163 and #181 - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: The fix was originally suggested by @phaux and make HTMLHint checking the root for the config file. #### Proposed changes: - Change the tmpConfigFilve variable. - Force the console to "break" if base is not found.
**Fixes**: #163 and #181 - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: The fix was originally suggested by @phaux and make HTMLHint checking the root for the config file. #### Proposed changes: - Change the tmpConfigFilve variable. - Force the console to "break" if base is not found.
**Fixes**: #163 and #181 - [x] Check the commit's or even all commits' message styles matches our requested structure. - [x] Check your code additions will fail neither code linting checks nor unit test. #### Short description of what this resolves: The fix was originally suggested by @phaux and make HTMLHint checking the root for the config file. #### Proposed changes: - Change the tmpConfigFilve variable. - Force the console to "break" if base is not found.
Make htmlhint check the root for the config file. Fixes #163