New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add acceptance test that 404 errors from registry do not get cached #28

Closed

Nitive wants to merge 2 commits into yannh:master from Nitive:do-not-cache-404-error-test

Nitive commented Jan 8, 2021 •

edited

The was no problem with caching 404 responses so I just added test to confirm that

I based my work on #26 because there was added utility function to start registry
Diff for review: Nitive/kubeconform@cache-test...Nitive:do-not-cache-404-error-test

Nitive added 2 commits

January 7, 2021 15:56


          Add failing acceptance test for disk caching feature

a03c1cb


          Add acceptance test that 404 errors from registry do not get cached

0f6da42

Nitive mentioned this pull request

Cache schemas to disk #21

Closed

Owner

yannh commented Jan 9, 2021

Hi @Nitive , thanks a lot for your time and your contributions 🙇 I think we could do something simpler, please check out #29 and let me know what you think, it should also cover this case. Thanks!

Author

Nitive commented Jan 9, 2021

@yannh Looks good to me, the only thing I would change is schema cache fixture location. I left a comment in #29

Nitive closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment