Add test for refs caching #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nitive
commented
Jan 9, 2021
| @test "Cache not only original schema but also refs to other schemas" { | ||
| run bin/kubeconform -schema-location './fixtures/registry/{{ .ResourceKind }}{{ .KindSuffix }}-with-ref.json' fixtures/test_crd.yaml | ||
| [ "$status" -eq 0 ] | ||
| [ "`ls cache/ | wc -l`" -eq 1 ] |
There was a problem hiding this comment.
Actual value is 0 because no refs got cached
There was a problem hiding this comment.
I think the better test would be
- Run kubeconform with internet access
- Disable network
- Run kubeconform again and check that status hasn't changed
But then we need to block network somehow. Maybe with DNS hack or somehow better
| "metadata": { | ||
| "$ref": "https://kubernetesjsonschema.dev/v1.14.0/_definitions.json#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta", | ||
| "description": "Standard object metadata." | ||
| }, |
There was a problem hiding this comment.
Almost the same file as trainingjob-sagemaker-v1.json with such change:
"metadata": {
- "type": "object",
+ "$ref": "https://kubernetesjsonschema.dev/v1.14.0/_definitions.json#/definitions/io.k8s.apimachinery.pkg.apis.meta.v1.ObjectMeta",
+ "description": "Standard object metadata."
},
Closed
|
yep that ll need patching gojsonschema.. might have a look, some day :) |
|
BTW thanks a lot for filing that bug xeipuuv/gojsonschema#322 👍 |
|
Closing, it looks like gojsonschema is not very actively maintained... and this will be fairly difficult to complete :( |
|
not sure what the point of a cache is if it can't be used offline |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with refs caching lays in gojsonschema code. There is a GET request which can't be cached on kubeconform side.
I think the best solution for caching refs would be to have http transport with supports caching and pass it to gojsonschema